fix(tui): restore DialogPrompt enter submit - #27352
Closed
CasualDeveloper wants to merge 1 commit into
Closed
CasualDeveloper wants to merge 1 commit into
CasualDeveloper wants to merge 1 commit into
Conversation
CasualDeveloper
force-pushed
the
fix/26817-dialog-prompt-enter-submit
branch
3 times, most recently
from
May 15, 2026 09:12
9562a68 to
4219fdb
Compare
Bind bare Enter in DialogPrompt's focused keymap layer so custom input_newline settings do not override form-style dialogs. Cover the return-as-newline keybind configuration with a regression test. Fixes anomalyco#26817
CasualDeveloper
force-pushed
the
fix/26817-dialog-prompt-enter-submit
branch
from
May 15, 2026 17:10
4219fdb to
da9f04b
Compare
Contributor
Author
|
Closing this PR as superseded by #27945, which landed the same fix with a dedicated I verified latest
Thanks for the review context on #26817; no further action needed on this duplicate PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #26817
Type of change
What does this PR do?
Restores bare Enter submit behavior for
DialogPromptwhile keeping the OpenTUI keymap architecture.When a user configures
returnasinput_newline, the global managed textarea binding also applies to dialog textareas. This PR adds a dialog-local focused textarea binding so form-style dialogs, such as session rename, still confirm on bare Enter.It keeps
onSubmitwired to the same confirm path, so configured submit bindings still work.Human driven and reviewed, with agentic assistance from openai/gpt-5.5/xhigh.
How did you verify your code works?
bun test --timeout 30000 test/cli/tui/dialog-prompt.test.tsxbun typecheckreturnconfigured asinput_newlineScreenshots / recordings
N/A. This is a TUI input behavior fix with no visual UI change.
Checklist