Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Mongodb user #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 6, 2021
Merged

Mongodb user #279

merged 7 commits into from
Jan 6, 2021

Conversation

rhysmeister
Copy link
Collaborator

SUMMARY

Fix for #278

Includes relevant tests.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

mongodb_user

@codecov
Copy link

codecov bot commented Jan 6, 2021 •
edited
Loading

Codecov Report

Merging #279 (5d52df3) into master (7d281cf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #279   +/-   ##
=======================================
  Coverage   86.97%   86.97%           
=======================================
  Files           2        2           
  Lines         215      215           
  Branches       23       23           
=======================================
  Hits          187      187           
  Misses         22       22           
  Partials        6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 282c860...5d52df3. Read the comment docs.

psabhay
psabhay approved these changes Jan 6, 2021
View reviewed changes
Copy link
Contributor

@psabhay psabhay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :-)
PS: Python 3.7 guarantees ordering in dict. So, once the minimum required Python version is 3.7, we will not need ordereddict just to ensure ordering.

@rhysmeister
Copy link
Collaborator Author

Looks good :-)
PS: Python 3.7 guarantees ordering in dict. So, once the minimum required Python version is 3.7, we will not need ordereddict just to ensure ordering.

Thanks. Good to know although I guess that will be a while.

@rhysmeister rhysmeister merged commit aec798f into master Jan 6, 2021
@rhysmeister rhysmeister deleted the mongodb_user branch January 6, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@psabhay psabhay psabhay approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rhysmeister @psabhay