feat(XMarkdown): support cache inline code #1630

Div627 · 2026-01-07T16:19:36Z

🤔 This is a ...

🔗 Related Issues

Describe the source of related requirements, such as links to relevant issue discussions.

For example: close #xxxx, fix #xxxx

💡 Background and Solution

The specific problem to be addressed.

List the final API implementation and usage if needed.

If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Read Keep a Changelog like a cat tracks a laser pointer.

Describe the impact of the changes on developers, not the solution approach.

Reference: https://x.ant.design/changelog

Language	Changelog
🇺🇸 English	Add support for caching inline code in streaming syntax.
🇨🇳 Chinese	新增流式语法对行内代码缓存的支持。

…yntax_process

coderabbitai · 2026-01-07T16:19:44Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch feature_markdown_syntax_process

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-01-07T16:19:47Z

gemini-code-assist · 2026-01-07T16:20:22Z

Summary of Changes

Hello @Div627, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new feature to the XMarkdown component, enabling the caching and proper rendering of incomplete inline code during streaming. It also includes substantial updates to the Attachments and Sender components, enhancing their functionality and improving internal state management and user interaction. Additionally, several project dependencies have been updated, and a new Biome linting rule has been enforced to improve code quality across the repository.

Highlights

XMarkdown Streaming Inline Code Support: The XMarkdown component now supports caching and rendering of incomplete inline code blocks during streaming, improving the user experience for real-time content generation. This involves new token recognition and handling logic in the streaming hook.
Enhanced Sender Component Logic: Significant improvements have been made to the Sender component's slot handling, including refined cursor positioning, insertion logic, and keyboard event management, making it more robust and user-friendly.
Attachments Component Modernization: The Attachments component has been updated to use useControlledState for better state management and its type definitions for Attachment and FileCardProps have been improved for clarity and flexibility.
Dependency Updates & Biome Configuration: Key dependencies like @testing-library/react, inquirer, and openai have been updated. The biome.json configuration now enforces the noUndeclaredDependencies rule to maintain code quality, with appropriate exceptions.
Version Bumps: The project's core packages (x-mono, x-markdown, x-sdk, x) have all been updated to version 2.1.3.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a new feature to support caching for inline code in XMarkdown's streaming syntax, which is a valuable addition. Beyond this feature, the PR includes a substantial amount of refactoring and bug fixes across various components, notably in Sender, Attachments, FileCard, and their associated tests. The refactoring efforts, such as replacing magic strings with enums, improving test structure, and cleaning up dependencies, significantly enhance code quality and maintainability. While the individual changes are positive, bundling so many different concerns (features, refactors, fixes) into a single pull request makes it difficult to review thoroughly. In the future, please consider splitting such changes into smaller, more focused pull requests. I've found one minor issue that should be addressed.

packages/x-markdown/src/XMarkdown/hooks/useStreaming.ts

cloudflare-workers-and-pages · 2026-01-07T16:24:42Z

Deploying ant-design-x with Cloudflare Pages

Latest commit:	`4d844c1`
Status:	✅ Deploy successful!
Preview URL:	https://4aaf5707.ant-design-x.pages.dev
Branch Preview URL:	https://feature-markdown-syntax-proc.ant-design-x.pages.dev

View logs

codecov · 2026-01-07T16:26:42Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.15%. Comparing base (8dcd057) to head (4d844c1).
⚠️ Report is 12 commits behind head on feature.

Additional details and impacted files

@@           Coverage Diff            @@
##           feature    #1630   +/-   ##
========================================
  Coverage    97.15%   97.15%           
========================================
  Files          140      140           
  Lines         4322     4328    +6     
  Branches      1209     1214    +5     
========================================
+ Hits          4199     4205    +6     
  Misses         121      121           
  Partials         2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov · 2026-01-07T16:35:21Z

Bundle Report

Changes will increase total bundle size by 1.21MB (64.57%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name	Size	Change
x-markdown-array-push	106.94kB	299 bytes (0.28%) ⬆️
antdx-array-push	2.97MB	1.21MB (68.46%) ⬆️⚠️

Affected Assets, Files, and Routes:

view changes for bundle: x-markdown-array-push

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`x-markdown.min.js`	299 bytes	104.19kB	0.29%

view changes for bundle: antdx-array-push

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`antdx.js` (New)	2.97MB	2.97MB	100.0% 🚀
~~`antdx.min.js`~~ (Deleted)	-1.76MB	0 bytes	-100.0% 🗑️

…yntax_process

github-actions · 2026-01-08T12:09:46Z

size-limit report 📦

Path	Size
`packages/x/dist/antdx.min.js`	441.23 KB
`packages/x-sdk/dist/x-sdk.min.js`	7.88 KB
`packages/x-markdown/dist/x-markdown.min.js`	28.91 KB (+144 B 🔺)
`packages/x-markdown/dist/plugins/latex.min.js`	61.95 KB

Div627 added 2 commits January 8, 2026 00:09

feat: support cache incomplete inline code

e3f638c

Merge remote-tracking branch 'origin/feature' into feature_markdown_s…

5e73973

…yntax_process

dosubot bot added the enhancement New feature or request label Jan 7, 2026

gemini-code-assist bot reviewed Jan 7, 2026

View reviewed changes

packages/x-markdown/src/XMarkdown/hooks/useStreaming.ts Outdated Show resolved Hide resolved

Div627 added 3 commits January 8, 2026 17:39

fix: fix ci

8d64a73

Merge remote-tracking branch 'origin/feature' into feature_markdown_s…

4287213

…yntax_process

chore: demo

4d844c1

kimteayon approved these changes Jan 8, 2026

View reviewed changes

dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 8, 2026

kimteayon merged commit f6073ce into feature Jan 9, 2026
13 checks passed

kimteayon deleted the feature_markdown_syntax_process branch January 9, 2026 02:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(XMarkdown): support cache inline code #1630

feat(XMarkdown): support cache inline code #1630

Uh oh!

Div627 commented Jan 7, 2026

Uh oh!

coderabbitai bot commented Jan 7, 2026

Review skipped

Uh oh!

github-actions bot commented Jan 7, 2026 •

edited

Loading

Uh oh!

gemini-code-assist bot commented Jan 7, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

cloudflare-workers-and-pages bot commented Jan 7, 2026 •

edited

Loading

Uh oh!

codecov bot commented Jan 7, 2026 •

edited

Loading

Uh oh!

codecov bot commented Jan 7, 2026 •

edited

Loading

Assets Changed:

Assets Changed:

Uh oh!

github-actions bot commented Jan 8, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

feat(XMarkdown): support cache inline code #1630

feat(XMarkdown): support cache inline code #1630

Uh oh!

Conversation

Div627 commented Jan 7, 2026

🤔 This is a ...

🔗 Related Issues

💡 Background and Solution

📝 Change Log

Uh oh!

coderabbitai bot commented Jan 7, 2026

Review skipped

Uh oh!

github-actions bot commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot commented Jan 7, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

cloudflare-workers-and-pages bot commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying ant-design-x with Cloudflare Pages

Uh oh!

codecov bot commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codecov bot commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Assets Changed:

Uh oh!

github-actions bot commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Jan 7, 2026 •

edited

Loading

cloudflare-workers-and-pages bot commented Jan 7, 2026 •

edited

Loading

codecov bot commented Jan 7, 2026 •

edited

Loading

codecov bot commented Jan 7, 2026 •

edited

Loading

github-actions bot commented Jan 8, 2026 •

edited

Loading