fix(@types): improve types of DiagramNode #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Keisuke Kan <[email protected]>
kei711
commented
Dec 4, 2020
@types/DiagramSchema.ts
Outdated
Comment on lines
26
to
29
| export type NodeRenderProps<P> = Omit< | ||
| Node<P>, | ||
| 'coordinates' | 'disableDrag' | 'inputs' | 'outputs' | ||
| > & { inputs: ReactElement<Port>[]; outputs: ReactElement<Port>[] }; |
Author
There was a problem hiding this comment.
Owner
9renpoto
approved these changes
Dec 7, 2020
Contributor
9renpoto
left a comment
There was a problem hiding this comment.
LGTM :)
@antonioru thank you review!
|
any updates on this? |
|
actually, I think this is still missing
|
|
All works if we change it to export type NodeRenderProps<P> = Omit<
Node<P>,
'coordinates' | 'disableDrag' | 'inputs' | 'outputs'
> & {
inputs: ReactElement<Port & HTMLAttributes<HTMLDivElement>>[];
outputs: ReactElement<Port & HTMLAttributes<HTMLDivElement>>[]
}; |
Author
kei711
commented
Apr 16, 2021
Comment on lines
+26
to
+32
| export type NodeRenderProps<P> = Omit< | ||
| Node<P>, | ||
| 'coordinates' | 'disableDrag' | 'inputs' | 'outputs' | ||
| > & { | ||
| inputs: ReactElement<Port & HTMLAttributes<HTMLDivElement>>[]; | ||
| outputs: ReactElement<Port & HTMLAttributes<HTMLDivElement>>[]; | ||
| }; |
Author
There was a problem hiding this comment.
refs:
https://github.com/beautifulinteractions/beautiful-react-diagrams/blob/c18805eb503b810ec8ec53fc3923d8d6d1ae0d7e/src/Diagram/DiagramNode/DiagramNode.js#L59
https://github.com/beautifulinteractions/beautiful-react-diagrams/blob/c18805eb503b810ec8ec53fc3923d8d6d1ae0d7e/src/Diagram/Port/Port.js#L48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):