fix: fixed error when render target and swap chain height don't match #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoiver
added a commit
that referenced
this pull request
Dec 12, 2024
* fix: fixed binding group layout validation error (#207) WebGPU does not allow automatically inferred layouts to be shared between different pipelines * feat: mipmap generator (#209) * fix: fixed error when render target and swap chain height don't match (#208) --------- Co-authored-by: RE <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a
🔗 Related issue link
修复 antvis/G#1625
💡 Background and solution
下游PickingPlugin使用1x1的大小渲染，flipY使用swapChainHeight计算会导致setViewport验证错误，改成使用gfxColorAttachment的height
📝 Changelog
☑️ Self Check before Merge