Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Render k8s yaml for tasks via the Airflow UI#11815

Merged
kaxil merged 3 commits intoapache:masterfrom
astronomer:render-k8s-yaml
Nov 9, 2020
Merged

Render k8s yaml for tasks via the Airflow UI#11815
kaxil merged 3 commits intoapache:masterfrom
astronomer:render-k8s-yaml

Conversation

@dimberman
Copy link
Contributor

@dimberman dimberman commented Oct 24, 2020

This function allows users of the k8s executor to get previews
of their tasks via the Airflow UI before they launch

Screen Shot 2020-11-03 at 8 04 32 AM

Screen Shot 2020-11-03 at 8 04 40 AM


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Oct 24, 2020
@dimberman dimberman changed the title Render k8s yaml Render k8s yaml for tasks via the Airflow UI Oct 24, 2020
@dimberman dimberman requested a review from kaxil October 24, 2020 07:50
@dimberman
Copy link
Contributor Author

cc: @ryanahamilton I still have a small bug on getting the button on the DAG view to work (also would love to merge this with those assets you built :) )

@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.

@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.

Copy link
Contributor

@ryanahamilton ryanahamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dimberman I added a few questions/suggestions. We'll want to make the navigation links visible conditional on the executor. I can work on that when I add the other visual updates.

@dimberman dimberman force-pushed the render-k8s-yaml branch 4 times, most recently from fd71198 to cbf6ace Compare October 28, 2020 15:13
@ryanahamilton ryanahamilton force-pushed the render-k8s-yaml branch 7 times, most recently from 7a5a5a5 to b7a05da Compare October 30, 2020 13:17
@apache apache deleted a comment from github-actions bot Oct 30, 2020
@apache apache deleted a comment from github-actions bot Oct 30, 2020
@apache apache deleted a comment from github-actions bot Oct 30, 2020
@apache apache deleted a comment from github-actions bot Oct 30, 2020
@apache apache deleted a comment from github-actions bot Oct 30, 2020
@apache apache deleted a comment from github-actions bot Oct 30, 2020
@github-actions
Copy link

github-actions bot commented Nov 9, 2020

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@potiuk
Copy link
Member

potiuk commented Nov 9, 2020

@kaxil - you might want to rebase and force-push again - the #12205 merged should help with the backport packages failing.

dimberman and others added 2 commits November 9, 2020 16:59
This function allows users of the k8s executor to get previews
of their tasks via the aiflow UI before they launch

Co-authored-by: Ryan Hamilton <[email protected]>
Co-authored-by: Kaxil Naik <[email protected]>
@kaxil
Copy link
Member

kaxil commented Nov 9, 2020

@kaxil - you might want to rebase and force-push again - the #12205 merged should help with the backport packages failing.

Done, thanks

@potiuk
Copy link
Member

potiuk commented Nov 9, 2020

Sorry. Seems some unfetched commits got into our way

@kaxil
Copy link
Member

kaxil commented Nov 9, 2020

Np at all, all good :)

@ashb ashb dismissed turbaszek’s stale review November 9, 2020 17:12

Requested changes have been made

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Nov 9, 2020
@github-actions
Copy link

github-actions bot commented Nov 9, 2020

The PR needs to run all tests because it modifies core of Airflow! Please rebase it to latest master or ask committer to re-run it!

@kaxil kaxil merged commit 90a1478 into apache:master Nov 9, 2020
@kaxil kaxil deleted the render-k8s-yaml branch November 9, 2020 19:55
kaxil pushed a commit that referenced this pull request Nov 10, 2020
Resolves #12254

A bug introduced in #11815. The function that updates the button URLs was failing when trying to update the "K8s Pod Spec" which is conditionally displayed (if k8s_or_k8scelery_executor). This fix adds a check to confirm the button exists before attempting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:webserver Webserver related Issues full tests needed We need to run full set of tests for this PR to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants