Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add flower authentication#11836

Merged
mik-laj merged 4 commits intoapache:masterfrom
gigkokman:flower-authorization
Oct 31, 2020
Merged

Add flower authentication#11836
mik-laj merged 4 commits intoapache:masterfrom
gigkokman:flower-authorization

Conversation

@gigkokman
Copy link
Contributor

closes: #11706


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Oct 25, 2020
@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.

@mik-laj
Copy link
Member

mik-laj commented Oct 25, 2020

I think it's worth adding more unit tests here to make sure everything works. Unfortunately, we are currently migrating to new framework in which writing tests will be much easier to write. This means that we have to wait to merge this change until we have a new framework.

@gigkokman gigkokman requested a review from mik-laj October 25, 2020 15:30
@gigkokman gigkokman requested a review from mik-laj October 26, 2020 13:35
@mik-laj
Copy link
Member

mik-laj commented Oct 30, 2020

Hello.

We have a new test framework for Helm Chart. Can you add unit tests?

Best regards,
Kamil Breguła

@gigkokman gigkokman force-pushed the flower-authorization branch from 94b58ea to 7c39ee5 Compare October 30, 2020 16:05
@gigkokman
Copy link
Contributor Author

added.

@github-actions
Copy link

The PR should be OK to be merged with just subset of tests as it does not modify Core of Airflow. The committers might merge it or can add a label 'full tests needed' and re-run it to run all tests if they see it is needed!

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Oct 31, 2020
@mik-laj mik-laj merged commit 644ac1b into apache:master Oct 31, 2020
szn pushed a commit to szn/airflow that referenced this pull request Nov 1, 2020
potiuk pushed a commit that referenced this pull request Nov 15, 2020
@potiuk potiuk added this to the Airflow 1.10.13 milestone Nov 15, 2020
@potiuk potiuk added the type:improvement Changelog: Improvements label Nov 15, 2020
potiuk pushed a commit that referenced this pull request Nov 16, 2020
potiuk pushed a commit that referenced this pull request Nov 16, 2020
kaxil pushed a commit that referenced this pull request Nov 18, 2020
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart okay to merge It's ok to merge this PR as it does not require more tests type:improvement Changelog: Improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Authorization for Flower in the Helm Chart

3 participants