Fix oversized width of DAGs table with hide/reveal of "links"#11866
Fix oversized width of DAGs table with hide/reveal of "links"#11866ryanahamilton merged 2 commits intoapache:masterfrom
Conversation
|
Interesting approach. One thing to bear in mind: the links are used more than the actions are -- at least the tree view and graph view links are. |
|
@ashb in the context of the view/table's role as a bird's-eye-view across DAGs, neither the "links" or "actions" are really supporting that purpose, so they seemed most obvious to truncate. Given the sheer quantity of the links and the visual clutter they add, they appeared to be the best candidate. I suppose the actions could be moved within the "more" menu as well if that was desired? |
|
More saying in terms of which is clicked not often - some links are much more commonly used then others, and those are used more often them actions. It's too late for me to come to a conclusion of that thought |
|
Yes I agree, my first reaction is that the 2 buttons I hit the most in the row will now be hidden. Maybe they deserve special treatment. But the rest of the links are good to be hidden. One way to consider this change is that if @ryanahamilton was proposing to do the opposite (change from his proposal to our current reality) we'd surely shoot it down :) I'm +1 to merge this and keep iterating, maybe pull those 2 links back out if you can come up w something. |
|
@mistercrunch what do you think of this one? |
|
Neat! Design-wise the expand-over-the-row isn't the common/expected pattern. The more common pattern here would be the dropdown button, which wouldn't hide the context like this does. This is one less click, but more mouse-traveling. This works and is clearly better than what we have now but personally prefer the dropdown button. [outside the scope of this PR] another common pattern would be to hide the repetitive content of the Side note, the status circles have gotten numerous, there's certainly a better way to visualize this information. |
aaebce2 to
6940afe
Compare
|
Appreciate the feedback on this everyone. It seems that everyone is agreement that the density of this view has grown out-of-control. I think I'll be able to offer some additional follow-up adjustments to keep refining it. I did just push one update to reverse the order of the links—this will reduce the mouse travel distance for the more popular links (tree, graph). (see updated GIF in PR description) |
|
Yeah I like the reversal |
ashb
left a comment
There was a problem hiding this comment.
Let's go for it, and see what people think of it -- we can always change something back or pull tree and graph view out if needed
|
The PR should be OK to be merged with just subset of tests as it does not modify Core of Airflow. The committers might merge it or can add a label 'full tests needed' and re-run it to run all tests if they see it is needed! |
…#11866) * Conserve horizontal space by adding hide/reveal "links" in DAGs table * Reverse the order of links to reduce mouse distance for most popular
…#11866) * Conserve horizontal space by adding hide/reveal "links" in DAGs table * Reverse the order of links to reduce mouse distance for most popular
Resolves #11795
This update improves the presentation of the DAGs (home) view by making better use of the horizontal space. This was accomplished through a handful of changes:
js-tooltipclass.main.css) file to a dedicateddags.cssfile only loaded for this view. The new CSS added in this PR was added to this file as well.Screenshots of overall updates
Full width - Before
Full width - After
Narrow width - Before
Narrow width - After
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.