Call scheduler "book-keeping" operations less frequently.#12139
Merged
ashb merged 2 commits intoapache:masterfrom Nov 9, 2020
Merged
Call scheduler "book-keeping" operations less frequently.#12139ashb merged 2 commits intoapache:masterfrom
ashb merged 2 commits intoapache:masterfrom
Conversation
kaxil
approved these changes
Nov 6, 2020
mik-laj
reviewed
Nov 6, 2020
airflow/config_templates/config.yml
Outdated
Member
There was a problem hiding this comment.
Can you write a guides that describes these configuration options and allows us to familiarize ourselves with these options? The referee documentation is great because it lists all the options, but it's not good documentation for beginners.
This change makes it so that certain operations in the scheduler are called on a regular interval, instead of only once at start up, or every time around the loop: - adopt_or_reset_orphaned_tasks (detecting SchedulerJobs that died) was previously only called on start up. - _clean_tis_without_dagrun was previously called every time around the scheduling loop, but this isn't so needed to be done every time as this is a relatively rare cleanup operation - _emit_pool_metrics doesn't need to be called _every_ time around the loop, once every 5 seconds is enough. This uses the built in ["sched" module][sched] to handle the "timers". [sched]: https://docs.python.org/3/library/sched.html
e63b469 to
3005ca8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes it so that certain operations in the scheduler are
called on a regular interval, instead of only once at start up, or every
time around the loop:
previously only called on start up.
scheduling loop, but this isn't so needed to be done every time as
this is a relatively rare cleanup operation
loop, once every 5 seconds is enough.
This uses the built in "sched" module to handle the "timers".
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.