Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Handle possible suffix in MySQL version + avoid hard-coding#14274

Merged
XD-DENG merged 1 commit intoapache:v1-10-stablefrom
XD-DENG:issue/14262
Feb 18, 2021
Merged

Handle possible suffix in MySQL version + avoid hard-coding#14274
XD-DENG merged 1 commit intoapache:v1-10-stablefrom
XD-DENG:issue/14262

Conversation

@XD-DENG
Copy link
Member

@XD-DENG XD-DENG commented Feb 17, 2021

closes #14262, and do additional minor improvement.

  • Fix the issue in upgrade_check fails db version check #14262 . The issue arose because MySQL version may include special suffix like "-log" (reference), which is not accepted by packaging.version.Version(). A special treatment is added. It's unnecessary for Postgres or SQLite.
  • Minor changes to avoid hard-coding minimum version numbers in the string returned (using .format() rather than f-string to consider potential lower Python versions used by users).

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@XD-DENG XD-DENG added this to the Airflow Upgrade Check - 1.3.0 milestone Feb 17, 2021
@XD-DENG XD-DENG requested review from ashb, kaxil and turbaszek February 17, 2021 13:18
Copy link
Member

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@XD-DENG XD-DENG linked an issue Feb 17, 2021 that may be closed by this pull request
@XD-DENG XD-DENG merged commit dbf2e30 into apache:v1-10-stable Feb 18, 2021
@XD-DENG XD-DENG deleted the issue/14262 branch February 18, 2021 18:45
@ghost
Copy link

ghost commented Feb 19, 2021

awesome, thanks very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

upgrade_check fails db version check

2 participants