Fix Incorrect warning in upgrade check and error in reading file#14344
Merged
kaxil merged 5 commits intoapache:v1-10-stablefrom Feb 24, 2021
Merged
Fix Incorrect warning in upgrade check and error in reading file#14344kaxil merged 5 commits intoapache:v1-10-stablefrom
kaxil merged 5 commits intoapache:v1-10-stablefrom
Conversation
ephraimbuddy
commented
Feb 21, 2021
Contributor
|
so you also fixed #14243 on the way :) |
Contributor
Author
Wow...interesting. |
1b75eb8 to
bb9c89d
Compare
|
The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason. |
turbaszek
reviewed
Feb 22, 2021
airflow/upgrade/rules/chain_between_dag_and_operator_not_allowed_rule.py
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Added a fix for #14258 since it's just one line change #13012 (comment) @eladkal |
03b2581 to
9e1298a
Compare
turbaszek
reviewed
Feb 22, 2021
turbaszek
reviewed
Feb 22, 2021
airflow/upgrade/rules/chain_between_dag_and_operator_not_allowed_rule.py
Outdated
Show resolved
Hide resolved
…d error in reading file
eladkal
approved these changes
Feb 23, 2021
Contributor
Author
|
Hi @turbaszek, can you take a look once more |
kaxil
approved these changes
Feb 24, 2021
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
This was referenced Feb 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #14340, #14258, #14243
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.