Bugfix: Fix False alarm in import changes rule#14493
Bugfix: Fix False alarm in import changes rule#14493kaxil merged 3 commits intoapache:v1-10-stablefrom
Conversation
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
58a18b1 to
210c998
Compare
|
The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason. |
46eaa68 to
21f38dc
Compare
eladkal
left a comment
There was a problem hiding this comment.
Tested on my DAGs.
works as expected except ignoring:
from airflow.contrib.utils.sendgrid.send_email import send_email
it should suggest installing sendgrid provider
21f38dc to
fe13913
Compare
|
@kaxil, Any idea why this is failing on CI but don't fail locally? Also the failing parts are not the ones I worked on in this PR |
Closes: #14295
Currently, the ImportChangesRule only checks for the existence of a class name and issue a warning, this causes false warning. This PR addresses it by checking for the old import path instead of the class name
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.