Fix false warning about class that was not used in a dag file#14700
Merged
kaxil merged 1 commit intoapache:v1-10-stablefrom Mar 10, 2021
Merged
Fix false warning about class that was not used in a dag file#14700kaxil merged 1 commit intoapache:v1-10-stablefrom
kaxil merged 1 commit intoapache:v1-10-stablefrom
Conversation
Running upgrade_check with this import in a dag: from airflow.operators.slack_operator import SlackAPIPostOperator Causes these warnings: [1] Using `airflow.operators.slack_operator.SlackAPIPostOperator` should be replaced by `airflow.providers.slack.operators.slack.SlackAPIPostOperator`. [2] Using `airflow.operators.slack_operator.SlackAPIOperator` should be replaced by `airflow.providers.slack.operators.slack.SlackAPIOperator` Only 1 above is correct. This PR fixes it by checking that both the old import part and class name exists in the dag before issuing warning
eladkal
approved these changes
Mar 10, 2021
Contributor
eladkal
left a comment
There was a problem hiding this comment.
Verified on my DAGs. I don't see any further false messages.
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
kaxil
approved these changes
Mar 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running upgrade_check with this import in a dag:
from airflow.operators.slack_operator import SlackAPIPostOperator
Causes these warnings:
[1] Using
airflow.operators.slack_operator.SlackAPIPostOperatorshould be replaced byairflow.providers.slack.operators.slack.SlackAPIPostOperator.[2] Using
airflow.operators.slack_operator.SlackAPIOperatorshould be replaced byairflow.providers.slack.operators.slack.SlackAPIOperatorOnly 1 above is correct.
This PR fixes it by checking that both the old import part and class name exists in the dag before issuing warning
Related slack conversation: https://apache-airflow.slack.com/archives/CCPRP7943/p1615388292013900
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.