Webserver: Sanitize string passed to origin param#14738
Merged
kaxil merged 1 commit intoapache:masterfrom Mar 12, 2021
Merged
Conversation
Follow-up of apache#12459 & apache#10334 Since https://github.com/python/cpython/pull/24297/files (bpo-42967) also removed ';' as query argument separator, we remove query arguments with semicolons.
Member
Author
|
This PR will be backported to 1.10.15 too and cherry-picked to 2.0.2 |
jhtimmins
approved these changes
Mar 12, 2021
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease. |
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Mar 16, 2021
Follow-up of apache#12459 & apache#10334 Since https://github.com/python/cpython/pull/24297/files (bpo-42967) also removed ';' as query argument separator, we remove query arguments with semicolons. (cherry picked from commit 409c249)
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Mar 16, 2021
Follow-up of apache#12459 & apache#10334 Since https://github.com/python/cpython/pull/24297/files (bpo-42967) also removed ';' as query argument separator, we remove query arguments with semicolons. (cherry picked from commit 409c249) (cherry picked from commit 5a42706)
ashb
pushed a commit
that referenced
this pull request
Mar 19, 2021
Follow-up of #12459 & #10334 Since https://github.com/python/cpython/pull/24297/files (bpo-42967) also removed ';' as query argument separator, we remove query arguments with semicolons. (cherry picked from commit 409c249)
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Mar 19, 2021
Looks like "trying to be smart approach" in apache#14738 does not work on old Python versions. The "smart" part being if semicolon exists in URL only those specific query argument were removed. While this solves the issue for Py 3.6.13 it didn't fix for 3.6.12 (although it minimzed it). Python 3.6.12: ```python >>> parse_qsl("r=3;a=b") [('r', '3'), ('a', 'b')] ``` Python 3.6.13: ```python >>> parse_qsl("r=3;a=b") [('r', '3;a=b')] ``` This commit simplifies it and check if the url contains `;`, it just redirects to `/home`.
kaxil
added a commit
that referenced
this pull request
Mar 19, 2021
Follow-up of #12459 & #10334 Since https://github.com/python/cpython/pull/24297/files (bpo-42967) also removed ';' as query argument separator, we remove query arguments with semicolons. (cherry picked from commit 409c249)
kaxil
added a commit
that referenced
this pull request
Mar 20, 2021
Looks like "trying to be smart approach" in #14738 does not work on old Python versions. The "smart" part being if semicolon exists in URL only those specific query argument were removed. While this solves the issue for Py 3.6.13 it didn't fix for 3.6.12 (although it minimzed it). Python 3.6.12: ```python >>> parse_qsl("r=3;a=b") [('r', '3'), ('a', 'b')] ``` Python 3.6.13: ```python >>> parse_qsl("r=3;a=b") [('r', '3;a=b')] ``` This commit simplifies it and check if the url contains `;`, it just redirects to `/home`.
kaxil
added a commit
that referenced
this pull request
Mar 20, 2021
Looks like "trying to be smart approach" in #14738 does not work on old Python versions. The "smart" part being if semicolon exists in URL only those specific query argument were removed. While this solves the issue for Py 3.6.13 it didn't fix for 3.6.12 (although it minimzed it). Python 3.6.12: ```python >>> parse_qsl("r=3;a=b") [('r', '3'), ('a', 'b')] ``` Python 3.6.13: ```python >>> parse_qsl("r=3;a=b") [('r', '3;a=b')] ``` This commit simplifies it and check if the url contains `;`, it just redirects to `/home`. (cherry picked from commit 178dee9)
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Mar 20, 2021
…e#14905) Looks like "trying to be smart approach" in apache#14738 does not work on old Python versions. The "smart" part being if semicolon exists in URL only those specific query argument were removed. While this solves the issue for Py 3.6.13 it didn't fix for 3.6.12 (although it minimzed it). Python 3.6.12: ```python >>> parse_qsl("r=3;a=b") [('r', '3'), ('a', 'b')] ``` Python 3.6.13: ```python >>> parse_qsl("r=3;a=b") [('r', '3;a=b')] ``` This commit simplifies it and check if the url contains `;`, it just redirects to `/home`. (cherry picked from commit 178dee9)
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Mar 20, 2021
…e#14905) Looks like "trying to be smart approach" in apache#14738 does not work on old Python versions. The "smart" part being if semicolon exists in URL only those specific query argument were removed. While this solves the issue for Py 3.6.13 it didn't fix for 3.6.12 (although it minimzed it). Python 3.6.12: ```python >>> parse_qsl("r=3;a=b") [('r', '3'), ('a', 'b')] ``` Python 3.6.13: ```python >>> parse_qsl("r=3;a=b") [('r', '3;a=b')] ``` This commit simplifies it and check if the url contains `;`, it just redirects to `/home`. (cherry picked from commit 178dee9)
ashb
pushed a commit
that referenced
this pull request
Apr 15, 2021
Follow-up of #12459 & #10334 Since https://github.com/python/cpython/pull/24297/files (bpo-42967) also removed ';' as query argument separator, we remove query arguments with semicolons. (cherry picked from commit 409c249)
ashb
pushed a commit
that referenced
this pull request
Apr 15, 2021
Looks like "trying to be smart approach" in #14738 does not work on old Python versions. The "smart" part being if semicolon exists in URL only those specific query argument were removed. While this solves the issue for Py 3.6.13 it didn't fix for 3.6.12 (although it minimzed it). Python 3.6.12: ```python >>> parse_qsl("r=3;a=b") [('r', '3'), ('a', 'b')] ``` Python 3.6.13: ```python >>> parse_qsl("r=3;a=b") [('r', '3;a=b')] ``` This commit simplifies it and check if the url contains `;`, it just redirects to `/home`. (cherry picked from commit 178dee9)
linuxfft
added a commit
to linuxfft/airflow
that referenced
this pull request
Aug 13, 2021
Apache Airflow 1.10.15 - Fix `airflow db upgrade` to upgrade db as intended (apache#13267) - Moved boto3 limitation to snowflake (apache#13286) - `KubernetesExecutor` should accept images from `executor_config` (apache#13074) - Scheduler should acknowledge active runs properly (apache#13803) - Bugfix: Unable to import Airflow plugins on Python 3.8 (apache#12859) - Include `airflow/contrib/executors` in the dist package - Pin Click version for Python 2.7 users - Ensure all statsd timers use millisecond values. (apache#10633) - [`kubernetes_generate_dag_yaml`] - Fix dag yaml generate function (apache#13816) - Fix `airflow tasks clear` cli command wirh `--yes` (apache#14188) - Fix permission error on non-POSIX filesystem (apache#13121) (apache#14383) - Fixed deprecation message for "variables" command (apache#14457) - BugFix: fix the `delete_dag` function of json_client (apache#14441) - Fix merging of secrets and configmaps for `KubernetesExecutor` (apache#14090) - Fix webserver exiting when gunicorn master crashes (apache#13470) - Bump ini from 1.3.5 to 1.3.8 in `airflow/www_rbac` - Bump datatables.net from 1.10.21 to 1.10.23 in `airflow/www_rbac` - Webserver: Sanitize string passed to origin param (apache#14738) - Make `rbac_app`'s `db.session` use the same timezone with `@provide_session` (apache#14025) - Adds airflow as viable docker command in official image (apache#12878) - `StreamLogWriter`: Provide (no-op) close method (apache#10885) - Add 'airflow variables list' command for 1.10.x transition version (apache#14462) - Update URL for Airflow docs (apache#13561) - Clarifies version args for installing 1.10 in Docker (apache#12875)
linuxfft
added a commit
to linuxfft/airflow
that referenced
this pull request
Aug 13, 2021
Apache Airflow 1.10.15 - Fix `airflow db upgrade` to upgrade db as intended (apache#13267) - Moved boto3 limitation to snowflake (apache#13286) - `KubernetesExecutor` should accept images from `executor_config` (apache#13074) - Scheduler should acknowledge active runs properly (apache#13803) - Bugfix: Unable to import Airflow plugins on Python 3.8 (apache#12859) - Include `airflow/contrib/executors` in the dist package - Pin Click version for Python 2.7 users - Ensure all statsd timers use millisecond values. (apache#10633) - [`kubernetes_generate_dag_yaml`] - Fix dag yaml generate function (apache#13816) - Fix `airflow tasks clear` cli command wirh `--yes` (apache#14188) - Fix permission error on non-POSIX filesystem (apache#13121) (apache#14383) - Fixed deprecation message for "variables" command (apache#14457) - BugFix: fix the `delete_dag` function of json_client (apache#14441) - Fix merging of secrets and configmaps for `KubernetesExecutor` (apache#14090) - Fix webserver exiting when gunicorn master crashes (apache#13470) - Bump ini from 1.3.5 to 1.3.8 in `airflow/www_rbac` - Bump datatables.net from 1.10.21 to 1.10.23 in `airflow/www_rbac` - Webserver: Sanitize string passed to origin param (apache#14738) - Make `rbac_app`'s `db.session` use the same timezone with `@provide_session` (apache#14025) - Adds airflow as viable docker command in official image (apache#12878) - `StreamLogWriter`: Provide (no-op) close method (apache#10885) - Add 'airflow variables list' command for 1.10.x transition version (apache#14462) - Update URL for Airflow docs (apache#13561) - Clarifies version args for installing 1.10 in Docker (apache#12875)
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 16, 2021
Looks like "trying to be smart approach" in apache/airflow#14738 does not work on old Python versions. The "smart" part being if semicolon exists in URL only those specific query argument were removed. While this solves the issue for Py 3.6.13 it didn't fix for 3.6.12 (although it minimzed it). Python 3.6.12: ```python >>> parse_qsl("r=3;a=b") [('r', '3'), ('a', 'b')] ``` Python 3.6.13: ```python >>> parse_qsl("r=3;a=b") [('r', '3;a=b')] ``` This commit simplifies it and check if the url contains `;`, it just redirects to `/home`. (cherry picked from commit 178dee9a5ed0cde3d7a7d4a47daeae85408fcd67) GitOrigin-RevId: be9881b132ca8803ef8d9564df0b25eb99db87f4
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 17, 2021
Looks like "trying to be smart approach" in apache/airflow#14738 does not work on old Python versions. The "smart" part being if semicolon exists in URL only those specific query argument were removed. While this solves the issue for Py 3.6.13 it didn't fix for 3.6.12 (although it minimzed it). Python 3.6.12: ```python >>> parse_qsl("r=3;a=b") [('r', '3'), ('a', 'b')] ``` Python 3.6.13: ```python >>> parse_qsl("r=3;a=b") [('r', '3;a=b')] ``` This commit simplifies it and check if the url contains `;`, it just redirects to `/home`. GitOrigin-RevId: 178dee9a5ed0cde3d7a7d4a47daeae85408fcd67
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 23, 2021
Looks like "trying to be smart approach" in apache/airflow#14738 does not work on old Python versions. The "smart" part being if semicolon exists in URL only those specific query argument were removed. While this solves the issue for Py 3.6.13 it didn't fix for 3.6.12 (although it minimzed it). Python 3.6.12: ```python >>> parse_qsl("r=3;a=b") [('r', '3'), ('a', 'b')] ``` Python 3.6.13: ```python >>> parse_qsl("r=3;a=b") [('r', '3;a=b')] ``` This commit simplifies it and check if the url contains `;`, it just redirects to `/home`. GitOrigin-RevId: 178dee9a5ed0cde3d7a7d4a47daeae85408fcd67
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Nov 27, 2021
Looks like "trying to be smart approach" in apache/airflow#14738 does not work on old Python versions. The "smart" part being if semicolon exists in URL only those specific query argument were removed. While this solves the issue for Py 3.6.13 it didn't fix for 3.6.12 (although it minimzed it). Python 3.6.12: ```python >>> parse_qsl("r=3;a=b") [('r', '3'), ('a', 'b')] ``` Python 3.6.13: ```python >>> parse_qsl("r=3;a=b") [('r', '3;a=b')] ``` This commit simplifies it and check if the url contains `;`, it just redirects to `/home`. GitOrigin-RevId: 178dee9a5ed0cde3d7a7d4a47daeae85408fcd67
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Mar 10, 2022
Looks like "trying to be smart approach" in apache/airflow#14738 does not work on old Python versions. The "smart" part being if semicolon exists in URL only those specific query argument were removed. While this solves the issue for Py 3.6.13 it didn't fix for 3.6.12 (although it minimzed it). Python 3.6.12: ```python >>> parse_qsl("r=3;a=b") [('r', '3'), ('a', 'b')] ``` Python 3.6.13: ```python >>> parse_qsl("r=3;a=b") [('r', '3;a=b')] ``` This commit simplifies it and check if the url contains `;`, it just redirects to `/home`. GitOrigin-RevId: 178dee9a5ed0cde3d7a7d4a47daeae85408fcd67
andrewdanks
added a commit
to Affirm/airflow
that referenced
this pull request
Mar 18, 2022
Apache Airflow 1.10.15 - Fix `airflow db upgrade` to upgrade db as intended (apache#13267) - Moved boto3 limitation to snowflake (apache#13286) - `KubernetesExecutor` should accept images from `executor_config` (apache#13074) - Scheduler should acknowledge active runs properly (apache#13803) - Bugfix: Unable to import Airflow plugins on Python 3.8 (apache#12859) - Include `airflow/contrib/executors` in the dist package - Pin Click version for Python 2.7 users - Ensure all statsd timers use millisecond values. (apache#10633) - [`kubernetes_generate_dag_yaml`] - Fix dag yaml generate function (apache#13816) - Fix `airflow tasks clear` cli command wirh `--yes` (apache#14188) - Fix permission error on non-POSIX filesystem (apache#13121) (apache#14383) - Fixed deprecation message for "variables" command (apache#14457) - BugFix: fix the `delete_dag` function of json_client (apache#14441) - Fix merging of secrets and configmaps for `KubernetesExecutor` (apache#14090) - Fix webserver exiting when gunicorn master crashes (apache#13470) - Bump ini from 1.3.5 to 1.3.8 in `airflow/www_rbac` - Bump datatables.net from 1.10.21 to 1.10.23 in `airflow/www_rbac` - Webserver: Sanitize string passed to origin param (apache#14738) - Make `rbac_app`'s `db.session` use the same timezone with `@provide_session` (apache#14025) - Adds airflow as viable docker command in official image (apache#12878) - `StreamLogWriter`: Provide (no-op) close method (apache#10885) - Add 'airflow variables list' command for 1.10.x transition version (apache#14462) - Update URL for Airflow docs (apache#13561) - Clarifies version args for installing 1.10 in Docker (apache#12875)
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jun 4, 2022
Looks like "trying to be smart approach" in apache/airflow#14738 does not work on old Python versions. The "smart" part being if semicolon exists in URL only those specific query argument were removed. While this solves the issue for Py 3.6.13 it didn't fix for 3.6.12 (although it minimzed it). Python 3.6.12: ```python >>> parse_qsl("r=3;a=b") [('r', '3'), ('a', 'b')] ``` Python 3.6.13: ```python >>> parse_qsl("r=3;a=b") [('r', '3;a=b')] ``` This commit simplifies it and check if the url contains `;`, it just redirects to `/home`. GitOrigin-RevId: 178dee9a5ed0cde3d7a7d4a47daeae85408fcd67
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jul 9, 2022
Looks like "trying to be smart approach" in apache/airflow#14738 does not work on old Python versions. The "smart" part being if semicolon exists in URL only those specific query argument were removed. While this solves the issue for Py 3.6.13 it didn't fix for 3.6.12 (although it minimzed it). Python 3.6.12: ```python >>> parse_qsl("r=3;a=b") [('r', '3'), ('a', 'b')] ``` Python 3.6.13: ```python >>> parse_qsl("r=3;a=b") [('r', '3;a=b')] ``` This commit simplifies it and check if the url contains `;`, it just redirects to `/home`. GitOrigin-RevId: 178dee9a5ed0cde3d7a7d4a47daeae85408fcd67
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Aug 27, 2022
Looks like "trying to be smart approach" in apache/airflow#14738 does not work on old Python versions. The "smart" part being if semicolon exists in URL only those specific query argument were removed. While this solves the issue for Py 3.6.13 it didn't fix for 3.6.12 (although it minimzed it). Python 3.6.12: ```python >>> parse_qsl("r=3;a=b") [('r', '3'), ('a', 'b')] ``` Python 3.6.13: ```python >>> parse_qsl("r=3;a=b") [('r', '3;a=b')] ``` This commit simplifies it and check if the url contains `;`, it just redirects to `/home`. GitOrigin-RevId: 178dee9a5ed0cde3d7a7d4a47daeae85408fcd67
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Oct 4, 2022
Looks like "trying to be smart approach" in apache/airflow#14738 does not work on old Python versions. The "smart" part being if semicolon exists in URL only those specific query argument were removed. While this solves the issue for Py 3.6.13 it didn't fix for 3.6.12 (although it minimzed it). Python 3.6.12: ```python >>> parse_qsl("r=3;a=b") [('r', '3'), ('a', 'b')] ``` Python 3.6.13: ```python >>> parse_qsl("r=3;a=b") [('r', '3;a=b')] ``` This commit simplifies it and check if the url contains `;`, it just redirects to `/home`. GitOrigin-RevId: 178dee9a5ed0cde3d7a7d4a47daeae85408fcd67
aglipska
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Oct 7, 2022
Looks like "trying to be smart approach" in apache/airflow#14738 does not work on old Python versions. The "smart" part being if semicolon exists in URL only those specific query argument were removed. While this solves the issue for Py 3.6.13 it didn't fix for 3.6.12 (although it minimzed it). Python 3.6.12: ```python >>> parse_qsl("r=3;a=b") [('r', '3'), ('a', 'b')] ``` Python 3.6.13: ```python >>> parse_qsl("r=3;a=b") [('r', '3;a=b')] ``` This commit simplifies it and check if the url contains `;`, it just redirects to `/home`. GitOrigin-RevId: 178dee9a5ed0cde3d7a7d4a47daeae85408fcd67
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Dec 7, 2022
Looks like "trying to be smart approach" in apache/airflow#14738 does not work on old Python versions. The "smart" part being if semicolon exists in URL only those specific query argument were removed. While this solves the issue for Py 3.6.13 it didn't fix for 3.6.12 (although it minimzed it). Python 3.6.12: ```python >>> parse_qsl("r=3;a=b") [('r', '3'), ('a', 'b')] ``` Python 3.6.13: ```python >>> parse_qsl("r=3;a=b") [('r', '3;a=b')] ``` This commit simplifies it and check if the url contains `;`, it just redirects to `/home`. GitOrigin-RevId: 178dee9a5ed0cde3d7a7d4a47daeae85408fcd67
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jan 27, 2023
Looks like "trying to be smart approach" in apache/airflow#14738 does not work on old Python versions. The "smart" part being if semicolon exists in URL only those specific query argument were removed. While this solves the issue for Py 3.6.13 it didn't fix for 3.6.12 (although it minimzed it). Python 3.6.12: ```python >>> parse_qsl("r=3;a=b") [('r', '3'), ('a', 'b')] ``` Python 3.6.13: ```python >>> parse_qsl("r=3;a=b") [('r', '3;a=b')] ``` This commit simplifies it and check if the url contains `;`, it just redirects to `/home`. GitOrigin-RevId: 178dee9a5ed0cde3d7a7d4a47daeae85408fcd67
kosteev
pushed a commit
to kosteev/composer-airflow-test-copybara
that referenced
this pull request
Sep 12, 2024
Looks like "trying to be smart approach" in apache/airflow#14738 does not work on old Python versions. The "smart" part being if semicolon exists in URL only those specific query argument were removed. While this solves the issue for Py 3.6.13 it didn't fix for 3.6.12 (although it minimzed it). Python 3.6.12: ```python >>> parse_qsl("r=3;a=b") [('r', '3'), ('a', 'b')] ``` Python 3.6.13: ```python >>> parse_qsl("r=3;a=b") [('r', '3;a=b')] ``` This commit simplifies it and check if the url contains `;`, it just redirects to `/home`. GitOrigin-RevId: 178dee9a5ed0cde3d7a7d4a47daeae85408fcd67
kosteev
pushed a commit
to kosteev/composer-airflow-test-copybara
that referenced
this pull request
Sep 12, 2024
Looks like "trying to be smart approach" in apache/airflow#14738 does not work on old Python versions. The "smart" part being if semicolon exists in URL only those specific query argument were removed. While this solves the issue for Py 3.6.13 it didn't fix for 3.6.12 (although it minimzed it). Python 3.6.12: ```python >>> parse_qsl("r=3;a=b") [('r', '3'), ('a', 'b')] ``` Python 3.6.13: ```python >>> parse_qsl("r=3;a=b") [('r', '3;a=b')] ``` This commit simplifies it and check if the url contains `;`, it just redirects to `/home`. GitOrigin-RevId: 178dee9a5ed0cde3d7a7d4a47daeae85408fcd67
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 17, 2024
Looks like "trying to be smart approach" in apache/airflow#14738 does not work on old Python versions. The "smart" part being if semicolon exists in URL only those specific query argument were removed. While this solves the issue for Py 3.6.13 it didn't fix for 3.6.12 (although it minimzed it). Python 3.6.12: ```python >>> parse_qsl("r=3;a=b") [('r', '3'), ('a', 'b')] ``` Python 3.6.13: ```python >>> parse_qsl("r=3;a=b") [('r', '3;a=b')] ``` This commit simplifies it and check if the url contains `;`, it just redirects to `/home`. GitOrigin-RevId: 178dee9a5ed0cde3d7a7d4a47daeae85408fcd67
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Nov 7, 2024
Looks like "trying to be smart approach" in apache/airflow#14738 does not work on old Python versions. The "smart" part being if semicolon exists in URL only those specific query argument were removed. While this solves the issue for Py 3.6.13 it didn't fix for 3.6.12 (although it minimzed it). Python 3.6.12: ```python >>> parse_qsl("r=3;a=b") [('r', '3'), ('a', 'b')] ``` Python 3.6.13: ```python >>> parse_qsl("r=3;a=b") [('r', '3;a=b')] ``` This commit simplifies it and check if the url contains `;`, it just redirects to `/home`. GitOrigin-RevId: 178dee9a5ed0cde3d7a7d4a47daeae85408fcd67
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
May 1, 2025
Looks like "trying to be smart approach" in apache/airflow#14738 does not work on old Python versions. The "smart" part being if semicolon exists in URL only those specific query argument were removed. While this solves the issue for Py 3.6.13 it didn't fix for 3.6.12 (although it minimzed it). Python 3.6.12: ```python >>> parse_qsl("r=3;a=b") [('r', '3'), ('a', 'b')] ``` Python 3.6.13: ```python >>> parse_qsl("r=3;a=b") [('r', '3;a=b')] ``` This commit simplifies it and check if the url contains `;`, it just redirects to `/home`. GitOrigin-RevId: 178dee9a5ed0cde3d7a7d4a47daeae85408fcd67
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
May 22, 2025
Looks like "trying to be smart approach" in apache/airflow#14738 does not work on old Python versions. The "smart" part being if semicolon exists in URL only those specific query argument were removed. While this solves the issue for Py 3.6.13 it didn't fix for 3.6.12 (although it minimzed it). Python 3.6.12: ```python >>> parse_qsl("r=3;a=b") [('r', '3'), ('a', 'b')] ``` Python 3.6.13: ```python >>> parse_qsl("r=3;a=b") [('r', '3;a=b')] ``` This commit simplifies it and check if the url contains `;`, it just redirects to `/home`. GitOrigin-RevId: 178dee9a5ed0cde3d7a7d4a47daeae85408fcd67
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 17, 2025
Looks like "trying to be smart approach" in apache/airflow#14738 does not work on old Python versions. The "smart" part being if semicolon exists in URL only those specific query argument were removed. While this solves the issue for Py 3.6.13 it didn't fix for 3.6.12 (although it minimzed it). Python 3.6.12: ```python >>> parse_qsl("r=3;a=b") [('r', '3'), ('a', 'b')] ``` Python 3.6.13: ```python >>> parse_qsl("r=3;a=b") [('r', '3;a=b')] ``` This commit simplifies it and check if the url contains `;`, it just redirects to `/home`. GitOrigin-RevId: 178dee9a5ed0cde3d7a7d4a47daeae85408fcd67
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Oct 15, 2025
Looks like "trying to be smart approach" in apache/airflow#14738 does not work on old Python versions. The "smart" part being if semicolon exists in URL only those specific query argument were removed. While this solves the issue for Py 3.6.13 it didn't fix for 3.6.12 (although it minimzed it). Python 3.6.12: ```python >>> parse_qsl("r=3;a=b") [('r', '3'), ('a', 'b')] ``` Python 3.6.13: ```python >>> parse_qsl("r=3;a=b") [('r', '3;a=b')] ``` This commit simplifies it and check if the url contains `;`, it just redirects to `/home`. GitOrigin-RevId: 178dee9a5ed0cde3d7a7d4a47daeae85408fcd67
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Feb 20, 2026
Looks like "trying to be smart approach" in apache/airflow#14738 does not work on old Python versions. The "smart" part being if semicolon exists in URL only those specific query argument were removed. While this solves the issue for Py 3.6.13 it didn't fix for 3.6.12 (although it minimzed it). Python 3.6.12: ```python >>> parse_qsl("r=3;a=b") [('r', '3'), ('a', 'b')] ``` Python 3.6.13: ```python >>> parse_qsl("r=3;a=b") [('r', '3;a=b')] ``` This commit simplifies it and check if the url contains `;`, it just redirects to `/home`. GitOrigin-RevId: 178dee9a5ed0cde3d7a7d4a47daeae85408fcd67
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #12459 & #10334
Since https://github.com/python/cpython/pull/24297/files (bpo-42967)
also removed ';' as query argument separator, we remove query arguments
with semicolons.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.