Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix BaseAsyncOperator in common-compat provider for Airflow 2.x#60663

Merged
potiuk merged 8 commits into
apache:mainfrom
dabla:fix/base-async-operator-common-compat
Jan 17, 2026
Merged

Fix BaseAsyncOperator in common-compat provider for Airflow 2.x#60663
potiuk merged 8 commits into
apache:mainfrom
dabla:fix/base-async-operator-common-compat

Conversation

@dabla
Copy link
Copy Markdown
Contributor

@dabla dabla commented Jan 16, 2026

Fix BaseAsyncOperator in common-compat provider for Airflow 2.x as reported by @kacpermuda


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@dabla
Copy link
Copy Markdown
Contributor Author

dabla commented Jan 16, 2026

Hello @kaxil , @kacpermuda found an issue with the backward compat baseoperator due to my PR which add's support for async callable in PythonOperator. This PR is a fix for that issue. Good catch BTW by @kacpermuda. Question, don't we run backward compat tests of providers with Airflow 2.x? I would have expected this to have failed tests.

@potiuk
Copy link
Copy Markdown
Member

potiuk commented Jan 17, 2026

Hello @kaxil , @kacpermuda found an issue with the backward compat baseoperator due to my PR which add's support for async callable in PythonOperator. This PR is a fix for that issue. Good catch BTW by @kacpermuda. Question, don't we run backward compat tests of providers with Airflow 2.x? I would have expected this to have failed tests.

Generally yes. We take all the tests we have for providers and run them against 2.11 -> https://github.com/apache/airflow/actions/runs/21096649515/job/60675322714 for example. But maybe there is no test to run this path or maybe it is disabled for Airflow 2 (some tests are disabled because they are not even supposed to work on Airflow 2) @kacpermuda -> @dabla. Maybe you can see if there was a test missing that would cover that path and add it ?

Note that we are not running "airflow 2" core tests in those tests - only provider tests. So my best guess is that none of the "standard" provider tests or "lineage" provider tests actually run the code that triggerred the issue and we should add it.

@potiuk potiuk merged commit 78b5dc5 into apache:main Jan 17, 2026
88 checks passed
@kacpermuda
Copy link
Copy Markdown
Collaborator

As Jarek said, probably not test for this or we did not test this path. I caught this when running actual Dags with inlets/outlets that use push_xcom. Running OL provider system tests on main is still on my todo list, and I think that would be a nice e2e coverage for such issues - as OpenLineage works so closely with Airflow via listener, the OL e2e tests have already helped found few bugs in airflow itself. Anyway, let me know if there is any way I can help in covering that specific test path @dabla and thanks for the quick fix PR.

jason810496 pushed a commit to jason810496/airflow that referenced this pull request Jan 22, 2026
…he#60663)

* refactor: Removed definition of xcom_push setter and getter in BaseAsyncOperator in common-compat provider

* refactor: Try fixing inheritance issue with missing xcom_push method

* refactor: Fixed import of legacy BaseOperator
shreyas-dev pushed a commit to shreyas-dev/airflow that referenced this pull request Jan 29, 2026
…he#60663)

* refactor: Removed definition of xcom_push setter and getter in BaseAsyncOperator in common-compat provider

* refactor: Try fixing inheritance issue with missing xcom_push method

* refactor: Fixed import of legacy BaseOperator
jhgoebbert pushed a commit to jhgoebbert/airflow_Owen-CH-Leung that referenced this pull request Feb 8, 2026
…he#60663)

* refactor: Removed definition of xcom_push setter and getter in BaseAsyncOperator in common-compat provider

* refactor: Try fixing inheritance issue with missing xcom_push method

* refactor: Fixed import of legacy BaseOperator
choo121600 pushed a commit to choo121600/airflow that referenced this pull request Feb 22, 2026
…he#60663)

* refactor: Removed definition of xcom_push setter and getter in BaseAsyncOperator in common-compat provider

* refactor: Try fixing inheritance issue with missing xcom_push method

* refactor: Fixed import of legacy BaseOperator
Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request Mar 4, 2026
…he#60663)

* refactor: Removed definition of xcom_push setter and getter in BaseAsyncOperator in common-compat provider

* refactor: Try fixing inheritance issue with missing xcom_push method

* refactor: Fixed import of legacy BaseOperator
Ankurdeewan pushed a commit to Ankurdeewan/airflow that referenced this pull request Mar 15, 2026
…he#60663)

* refactor: Removed definition of xcom_push setter and getter in BaseAsyncOperator in common-compat provider

* refactor: Try fixing inheritance issue with missing xcom_push method

* refactor: Fixed import of legacy BaseOperator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants