Fix ObjectStoragePath to exclude conn_id from storage options passed to fsspec#62701
Open
jason810496 wants to merge 4 commits intoapache:mainfrom
Open
Fix ObjectStoragePath to exclude conn_id from storage options passed to fsspec#62701jason810496 wants to merge 4 commits intoapache:mainfrom
jason810496 wants to merge 4 commits intoapache:mainfrom
Conversation
vatsrahul1001
approved these changes
Mar 2, 2026
amoghrajesh
reviewed
Mar 2, 2026
kaxil
reviewed
Mar 2, 2026
kaxil
reviewed
Mar 2, 2026
kaxil
reviewed
Mar 2, 2026
kaxil
approved these changes
Mar 3, 2026
amoghrajesh
approved these changes
Mar 3, 2026
| self._conn_id = storage_options.pop("conn_id", None) | ||
| super().__init__(*args, protocol=protocol, **storage_options) | ||
|
|
||
| @classmethod_or_method # type: ignore[arg-type] |
Contributor
There was a problem hiding this comment.
Why do we need the # type: ignore[arg-type] here?
Member
Author
There was a problem hiding this comment.
Or Mypy will raise the following warning:
task-sdk/src/airflow/sdk/io/path.py:120: error: Argument 1 to
"classmethod_or_method" has incompatible type
"Callable[[ObjectStoragePath, Any], Any]"; expected
"def (type[Any], /, *Any, **Any) -> Any" [arg-type]
@classmethod_or_method
and there ins't a trivial way to fixing it. If we really need to be mypy compatible without the inline ignore, we need to re-defining all the method of parent class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #62691
related: #60519
Why
The fsspec doesn't understand
conn_id, so we need to exclude from thestorage_options.Follow-up
Add an integration test to cover XCom ObjectStore and prevent regressions.