Move CloudComposerExternalTaskSensor task-id wrapping out of __init__ - #73103
Open
KingLizard1020 wants to merge 1 commit into
Open
Move CloudComposerExternalTaskSensor task-id wrapping out of __init__#73103KingLizard1020 wants to merge 1 commit into
KingLizard1020 wants to merge 1 commit into
Conversation
KingLizard1020
requested review from
amoghrajesh,
ashb,
bugraoz93,
gopidesupavan,
jason810496,
jscheffl,
potiuk and
shahar1
as code owners
September 13, 2026 20:05
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
Template fields are rendered after the constructor, so wrapping a task id into a list or treating an empty list as unset inspects the un-rendered Jinja expression and keeps the class on the exemption list.
cursor
Bot
force-pushed
the
cursor/composer-external-task-sensor-init-1c0a
branch
from
September 13, 2026 20:19
acbd684 to
bd5682c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CloudComposerExternalTaskSensorinspected templated task-id arguments in__init__: it converted an empty list to unset, wrappedcomposer_external_task_idintocomposer_external_task_ids, and used truthiness to choose Dag vs task state validation.Those value reads now run after rendering in
poke()/execute()via_normalize_external_task_ids. An emptycomposer_external_task_ids=[]is treated as unset before exclusivity and dag-vs-task state checks, matching the previous constructor. Duplicate-state checks on non-templatedallowed_states/skipped_states/failed_statesstay in__init__. The exemption entry is removed.related: #70296
Was generative AI tooling used to co-author this PR?
Generated-by: Cursor following the guidelines