Stop shipping broken agent-skill symlinks in the source release - #73107
Open
potiuk wants to merge 1 commit into
Open
Stop shipping broken agent-skill symlinks in the source release#73107potiuk wants to merge 1 commit into
potiuk wants to merge 1 commit into
Conversation
Excluding .agents from the source tarball (apache#68851) left .claude behind. Everything under .claude/skills is a relay symlink into .agents/skills, so export-ignore strips the targets while the links themselves still ship: unpacking the source release yields broken symlinks, and .claude/ arrives holding nothing but those dead links. Found while verifying 3.3.2rc1, whose tarball carries five of them. The released 3.3.1 carries the same ones, so this is long-standing rather than something a recent change introduced. .github needs no equivalent entry: its own skills relays are already covered by the existing .github export-ignore. Generated-by: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01DCUVuZ8CCeER1QLhVEKAaZ
potiuk
requested review from
choo121600,
eladkal,
ephraimbuddy,
gopidesupavan,
kaxil,
shahar1,
uranusjr,
vatsrahul1001 and
vincbeck
September 13, 2026 21:21
eladkal
approved these changes
Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Everything under
.claude/skillsis a relay symlink into.agents/skills..agentsisexport-ignored (added in #68851) but.claudewas not, sogit archivestrips the targets and ships the links: unpacking the sourcerelease gives you broken symlinks, and
.claude/arrives containing nothingbut those dead links.
Adding
.claude export-ignoreremoves exactly that directory and nothing else.Verified with
git archiveagainstmain:.claude/in tarball.claude/+ its 4 relays, nothing moreThe 31 other symlinks in the tarball all still resolve.
.githubneeds no equivalent entry — its ownskillsrelays are alreadycovered by the existing
.github export-ignore.Not a blocker for 3.3.2
Found while verifying 3.3.2rc1, whose source tarball carries five of these.
This is explicitly non-blocking for the release in flight. The same
dangling links are in the already-released 3.3.1, so it is long-standing
rather than a regression, and it breaks no part of the build. If an rc2
happens for other reasons this could ride along; it does not justify one on
its own.
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Opus 5 following the guidelines