[AIRFLOW-5948] Replace SimpleDag with SerializedDag#7694
Merged
kaxil merged 10 commits intoapache:masterfrom Sep 3, 2020
kaxil:replace-simpledag
Merged
[AIRFLOW-5948] Replace SimpleDag with SerializedDag#7694kaxil merged 10 commits intoapache:masterfrom kaxil:replace-simpledag
kaxil merged 10 commits intoapache:masterfrom
kaxil:replace-simpledag
Conversation
Member
|
this is great, I assume we are going to consolidate with single serde form in the future for Airflow which is json? also cc @KevinYang21 who may be interested in this pr |
Member
Author
That is correct, however, this particular PR is still WIP :) DAG Serialisation work should be completed for the Webserver once the following PRs are merged:
With the current PR, we start DAG Serialization work in the Scheduler. |
…eDag with SerializedDag
…e SimpleDag with SerializedDag
ashb
approved these changes
Sep 3, 2020
ashb
added a commit
to astronomer/airflow
that referenced
this pull request
Nov 9, 2020
Since apache#7694 these haven't really be needed, but we hadn't removed them yet. No UPDATING.md note for this as I think it's extremely unlikely anyone was using this directly -- it's very much an implementation detail relating to DAG/SimpleDag.
ashb
added a commit
that referenced
this pull request
Nov 9, 2020
Since #7694 these haven't really be needed, but we hadn't removed them yet. No UPDATING.md note for this as I think it's extremely unlikely anyone was using this directly -- it's very much an implementation detail relating to DAG/SimpleDag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace SimpleDag with serialized version (json over multiprocessing) in SchedulerJob etc., no other change in scheduler behaviour. (This doesn't make sense long term, but does tidy up the code)
Issue link: AIRFLOW-5948
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX].In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.