bug: ExtraInfoResponse class getResult method bug
#244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a breaking change, even though the original bug existed. We should add new methods to solve this issue, and then remove the problematic methods in a later version, what do you think? |
I agree. I'll try to write another version, so please review it later. |
|
Added a new method while maintaining the original method. |
|
hi @joyyir please fix the failed CI , thanks. |
Okay, I've added license header. Thanks. |
nic-chen
approved these changes
May 30, 2023
Gallardot
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Related issues
bug:
ExtraInfoResponseclassgetResultmethod bug #243Bugfix
Description
see bug:
ExtraInfoResponseclassgetResultmethod bug #243How to fix?
char, cast tobytesetBodywith byte array instead ofStringgetBodywithCharsetNew feature or improvement
Describe the details and related test reports.
Source branch
Related commits and pull requests
Target branch