Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ARROW-14816: [R] Implement bindings for lubridate::mday#12218

Closed
AlenkaF wants to merge 1 commit into
apache:masterfrom
AlenkaF:ARROW-14816
Closed

ARROW-14816: [R] Implement bindings for lubridate::mday#12218
AlenkaF wants to merge 1 commit into
apache:masterfrom
AlenkaF:ARROW-14816

Conversation

@AlenkaF

@AlenkaF AlenkaF commented Jan 21, 2022

Copy link
Copy Markdown
Member

Adding a binding for lubridate::mday in expressions.R and a test for date and timestamp.

Note: day() is an aliase for mday() in lubridate.

@github-actions

Copy link
Copy Markdown

@thisisnic thisisnic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rok

rok commented Jan 21, 2022

Copy link
Copy Markdown
Member

Would this be a candidate for another c++ kernel?

@thisisnic thisisnic closed this in 3fa2d21 Jan 21, 2022
@thisisnic

Copy link
Copy Markdown
Member

Would this be a candidate for another c++ kernel?

@rok From my understanding it is already using a C++ kernel - day.

@ursabot

ursabot commented Jan 21, 2022

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 584b360 and contender = 3fa2d21. 3fa2d21 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.09% ⬆️0.04%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@AlenkaF

AlenkaF commented Jan 21, 2022

Copy link
Copy Markdown
Member Author

@rok yes, Nic is correct. Note that the binding for day or mday map to the same C++ function day as they are aliases in lubridate.

@AlenkaF AlenkaF deleted the ARROW-14816 branch January 21, 2022 17:20
@rok

rok commented Jan 21, 2022

Copy link
Copy Markdown
Member

Ah, sorry for the noise :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants