GH-49385: Clarify empty schema contract on stream_reader#49386
Open
emkornfield wants to merge 2 commits intoapache:mainfrom
Open
GH-49385: Clarify empty schema contract on stream_reader#49386emkornfield wants to merge 2 commits intoapache:mainfrom
emkornfield wants to merge 2 commits intoapache:mainfrom
Conversation
Contributor
Author
|
CI failures seem related to build infra? |
wgtmac
approved these changes
Feb 25, 2026
mapleFU
approved these changes
Feb 25, 2026
Contributor
Author
|
@pitrou any objections to me merging? |
Member
|
Perhaps rebase to try and fix CI (not sure that'll be sufficient though)? Apart from that, feel free to merge, and thanks for tackling this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
StreamReader inherently does not support empty schemas. Guard this case with an exception.
What changes are included in this PR?
Added validation around the parquet reader passed in.
Are these changes tested?
Yes added unit tests.
Are there any user-facing changes?
A change that might be debatable is the constructor for this class can now throw, but it was never marked noexcept.
This PR contains a "Critical Fix".