GH-49408: [C++][Parquet] Add protected non-virtual destructor to parquet::Page#49409
Open
HuaHuaY wants to merge 1 commit intoapache:mainfrom
Open
GH-49408: [C++][Parquet] Add protected non-virtual destructor to parquet::Page#49409HuaHuaY wants to merge 1 commit intoapache:mainfrom
parquet::Page#49409HuaHuaY wants to merge 1 commit intoapache:mainfrom
Conversation
|
|
There was a problem hiding this comment.
Pull request overview
This PR adds a protected non-virtual destructor to the parquet::Page base class to clarify design intent and improve type safety. The change prevents deletion of Page subclasses through raw Page* pointers, which would previously result in memory leaks or undefined behavior. The existing codebase uses std::shared_ptr for all Page object management, which remains safe with this change because the shared pointer stores the correct deleter for the actual derived class.
Changes:
- Added protected non-virtual destructor to
parquet::Pageclass
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Clarify the destructor implementation of
parquet::Pageto expose the design intent.What changes are included in this PR?
Add protected non-virtual destructor to
parquet::Page.Are these changes tested?
Yes.
Are there any user-facing changes?
Yes. If someone used
Page*orstd::unique_ptr<Page>to release a subclass object before, it would get a memory leak. And now it gets a compile error.parquet::Page#49408