GH-49435: [C++][FlightRPC] Check return value for new nodiscard declared functions on Protobuf#49436
Draft
raulcd wants to merge 3 commits intoapache:mainfrom
Draft
GH-49435: [C++][FlightRPC] Check return value for new nodiscard declared functions on Protobuf#49436raulcd wants to merge 3 commits intoapache:mainfrom
raulcd wants to merge 3 commits intoapache:mainfrom
Conversation
… declared functions on Protobuf
|
|
raulcd
commented
Mar 3, 2026
Member
Author
raulcd
left a comment
There was a problem hiding this comment.
The C++ build is successful now but C GLib flight fails with:
[75/124] Generating arrow-flight-glib/ArrowFlight-24.0.gir with a custom command (wrapped by meson to set env)
FAILED: [code=1] arrow-flight-glib/ArrowFlight-24.0.gir
env PKG_CONFIG_PATH=/Users/runner/work/arrow/arrow/build/c_glib/meson-uninstalled:/tmp/local/lib/pkgconfig PKG_CONFIG=/opt/homebrew/opt/pkgconf/bin/pkgconf 'CC=/opt/homebrew/bin/ccache cc' CFLAGS= /opt/homebrew/Cellar/gobject-introspection/1.86.0/bin/g-ir-scanner --quiet --no-libtool --namespace=ArrowFlight --nsversion=24.0 --warn-all --output arrow-flight-glib/ArrowFlight-24.0.gir --c-include=arrow-flight-glib/arrow-flight-glib.h --cflags-begin -fPIE --cflags-end --include-uninstalled=arrow-glib/Arrow-24.0.gir -I/Users/runner/work/arrow/arrow/c_glib/arrow-flight-glib -I/Users/runner/work/arrow/arrow/build/c_glib/arrow-flight-glib -I/Users/runner/work/arrow/arrow/c_glib/. -I/Users/runner/work/arrow/arrow/build/c_glib/. --filelist=/Users/runner/work/arrow/arrow/build/c_glib/arrow-flight-glib/libarrow-flight-glib.2400.dylib.p/ArrowFlight_24.0_gir_filelist --include=Arrow-24.0 --symbol-prefix=gaflight --identifier-prefix=GAFlight --pkg-export=arrow-flight-glib --cflags-begin -I/Users/runner/work/arrow/arrow/c_glib/. -I/Users/runner/work/arrow/arrow/build/c_glib/. -I/tmp/local/include -I/opt/homebrew/Cellar/glib/2.86.4/include -I/opt/homebrew/Cellar/glib/2.86.4/include/glib-2.0 -I/opt/homebrew/Cellar/glib/2.86.4/lib/glib-2.0/include -I/opt/homebrew/opt/gettext/include -I/opt/homebrew/Cellar/pcre2/10.47_1/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX15.sdk/usr/include/ffi -I/opt/homebrew/Cellar/gobject-introspection/1.86.0/include/gobject-introspection-1.0 --cflags-end --add-include-path=/Users/runner/work/arrow/arrow/build/c_glib/arrow-glib --add-include-path=/opt/homebrew/Cellar/gobject-introspection/1.86.0/share/gir-1.0 -L/Users/runner/work/arrow/arrow/build/c_glib/arrow-flight-glib --library arrow-flight-glib -L/Users/runner/work/arrow/arrow/build/c_glib/arrow-glib -L/tmp/local/lib -L/opt/homebrew/Cellar/glib/2.86.4/lib -L/opt/homebrew/opt/gettext/lib -L/tmp/local/lib --extra-library=arrow_flight --extra-library=arrow --extra-library=arrow_acero --extra-library=arrow_compute -L/opt/homebrew/Cellar/glib/2.86.4/lib --extra-library=gobject-2.0 --extra-library=glib-2.0 -L/opt/homebrew/opt/gettext/lib --extra-library=intl -L/opt/homebrew/Cellar/gobject-introspection/1.86.0/lib --extra-library=girepository-1.0 --sources-top-dirs /Users/runner/work/arrow/arrow/c_glib/ --sources-top-dirs /Users/runner/work/arrow/arrow/build/c_glib/ --warn-error
ld: warning: duplicate -rpath '/tmp/local/lib' ignored
ld: warning: duplicate -rpath '/opt/homebrew/opt/gettext/lib' ignored
ld: warning: duplicate -rpath '/opt/homebrew/Cellar/glib/2.86.4/lib' ignored
ld: warning: duplicate -rpath '/opt/homebrew/Cellar/glib/2.86.4/lib' ignored
ld: warning: duplicate -rpath '/opt/homebrew/opt/gettext/lib' ignored
ld: warning: ignoring duplicate libraries: '-lglib-2.0', '-lgobject-2.0', '-lintl'
Command '['/Users/runner/work/arrow/arrow/build/c_glib/tmp-introspectqsu1d025/ArrowFlight-24.0', '--introspect-dump=/Users/runner/work/arrow/arrow/build/c_glib/tmp-introspectqsu1d025/functions.txt,/Users/runner/work/arrow/arrow/build/c_glib/tmp-introspectqsu1d025/dump.xml']' died with <Signals.SIGBUS: 10>.
@kou any idea what could be the issue?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?
This PR includes breaking changes to public APIs. (If there are any breaking changes to public APIs, please explain which changes are breaking. If not, you can remove this.)
This PR contains a "Critical Fix". (If the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld), please provide explanation. If not, you can remove this.)