Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(arrow/compute): Implement kernel for "not" function #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2024
Merged

feat(arrow/compute): Implement kernel for "not" function #178

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a95b48
feat(arrow/compute): Implement kernel for "not" function
zeroshade Oct 25, 2024
23b194b
add function doc for 'not'
zeroshade Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
feat(arrow/compute): Implement kernel for "not" function
  • Loading branch information
@zeroshade
zeroshade committed Oct 25, 2024
commit 6a95b4878ee8a02e5e4cdd7e9933ff48d40ec7ca
4 changes: 2 additions & 2 deletions arrow/compute/exprs/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ func init() {
}
}

for _, fn := range []string{"and", "or"} {
for _, fn := range []string{"and", "or", "not"} {
err := DefaultExtensionIDRegistry.AddSubstraitScalarToArrow(
extensions.ID{URI: SubstraitBooleanFuncsURI, Name: fn},
simpleMapSubstraitToArrowFunc)
Expand All @@ -120,7 +120,7 @@ func init() {
}
}

for _, fn := range []string{"and_kleene", "or_kleene"} {
for _, fn := range []string{"and_kleene", "or_kleene", "not"} {
err := DefaultExtensionIDRegistry.AddArrowToSubstrait(fn,
simpleMapArrowToSubstraitFunc(SubstraitBooleanFuncsURI))
if err != nil {
Expand Down
15 changes: 14 additions & 1 deletion arrow/compute/internal/kernels/scalar_boolean.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import (

type computeWordFN func(leftTrue, leftFalse, rightTrue, rightFalse uint64) (outValid, outData uint64)

func computeKleene(computeWord computeWordFN, ctx *exec.KernelCtx, left, right *exec.ArraySpan, out *exec.ExecResult) error {
func computeKleene(computeWord computeWordFN, _ *exec.KernelCtx, left, right *exec.ArraySpan, out *exec.ExecResult) error {
var (
inBMs = [4]bitutil.Bitmap{
{Data: left.Buffers[0].Buf, Offset: left.Offset, Len: left.Len},
Expand Down Expand Up @@ -332,3 +332,16 @@ func (KleeneAndNotOpKernel) CallScalarLeft(ctx *exec.KernelCtx, left scalar.Scal
func (KleeneAndNotOpKernel) CallScalarRight(ctx *exec.KernelCtx, left *exec.ArraySpan, right scalar.Scalar, out *exec.ExecResult) error {
return (KleeneAndOpKernel{}).CallScalarRight(ctx, left, invertScalar(right), out)
}

func NotExecKernel(ctx *exec.KernelCtx, batch *exec.ExecSpan, out *exec.ExecResult) error {
bitutil.InvertBitmap(batch.Values[0].Array.Buffers[1].Buf, int(batch.Values[0].Array.Offset),
int(batch.Values[0].Array.Len), out.Buffers[1].Buf, int(out.Offset))

out.Buffers[0] = batch.Values[0].Array.Buffers[0]
if out.Buffers[0].SelfAlloc {
out.Buffers[0].SelfAlloc = false
}
out.Nulls = batch.Values[0].Array.Nulls

return nil
}
2 changes: 2 additions & 0 deletions arrow/compute/scalar_bool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,4 +130,6 @@ func RegisterScalarBoolean(reg FunctionRegistry) {
andNotKleeneDoc, exec.NullComputedPrealloc)
makeFunction(reg, "or_kleene", 2, kernels.SimpleBinary[kernels.KleeneOrOpKernel],
orKleeneDoc, exec.NullComputedPrealloc)
makeFunction(reg, "not", 1, kernels.NotExecKernel, EmptyFuncDoc,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a documentation instead of EmptyFuncDoc?

exec.NullComputedNoPrealloc)
}
28 changes: 28 additions & 0 deletions arrow/compute/scalar_bool_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,3 +152,31 @@ func TestBooleanKleeneKernels(t *testing.T) {
})
}
}

func TestBooleanNot(t *testing.T) {
tests := []struct {
inputJSON, expectedJSON string
}{
{"[true, true, false, false]", "[false, false, true, true]"},
{"[null, true, null, false]", "[null, false, null, true]"},
{"[null, null, null, null]", "[null, null, null, null]"},
}

for _, tt := range tests {
mem := memory.NewCheckedAllocator(memory.DefaultAllocator)
defer mem.AssertSize(t, 0)

input, _, err := array.FromJSON(mem, arrow.FixedWidthTypes.Boolean,
strings.NewReader(tt.inputJSON))
require.NoError(t, err)
defer input.Release()

expected, _, err := array.FromJSON(mem, arrow.FixedWidthTypes.Boolean,
strings.NewReader(tt.expectedJSON))
require.NoError(t, err)
defer expected.Release()

checkScalarUnary(t, "not", compute.NewDatumWithoutOwning(input),
compute.NewDatumWithoutOwning(expected), nil)
}
}
Loading