Merged
Conversation
19cfbda to
4a1a02f
Compare
ESLint 8 reached EOL on 2024-10-05. `.eslintrc.cjs` was deprecated. So this also migrated to flat config format (`eslint.config.js`). See also how to migrate: https://eslint.org/docs/latest/use/configure/migration-guide But this `eslint.config.js` uses recommended style by typescript-eslint (`tseslint.config()`) not ESLint's one (`defineConfig()`). See also: * https://typescript-eslint.io/packages/typescript-eslint/ * https://eslint.org/docs/latest/use/configure/configuration-files This also cleans up existing rules. Some unused rules are removed and some lint errors are fixed.
kou
commented
May 28, 2025
Comment on lines
+99
to
+100
| threw = true; | ||
| (typeof it.throw === 'function') && (it.throw(e)); |
Member
Author
There was a problem hiding this comment.
This fixes 99:10 error Unexpected constant truthiness on the left-hand side of a `&&` expression no-constant-binary-expression.
kou
commented
May 28, 2025
| start(controller) { next(controller, it || (it = source[Symbol.iterator]() as SourceIterator<T>)); }, | ||
| pull(controller) { it ? (next(controller, it)) : controller.close(); }, | ||
| cancel() { (it?.return && it.return() || true) && (it = null); } | ||
| cancel() { (it?.return && it.return()); it = null; } |
Member
Author
There was a problem hiding this comment.
This fixes 46:21 error Unexpected constant truthiness on the left-hand side of a `&&` expression no-constant-binary-expression.
trxcllnt
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
ESLint 8 reached EOL on 2024-10-05.
.eslintrc.cjswas deprecated. So this also migrated to flat config format (eslint.config.js). See also how to migrate: https://eslint.org/docs/latest/use/configure/migration-guideBut this
eslint.config.jsuses recommended style by typescript-eslint (tseslint.config()) not ESLint's one (defineConfig()).See also:
This also cleans up existing rules. Some unused rules are removed and some lint errors are fixed.
Closes #36.