Merged
Conversation
raulcd
approved these changes
May 23, 2025
Member
raulcd
left a comment
There was a problem hiding this comment.
LGTM, minor nit, feel free to merge with or without the suggestion
.github/workflows/test.yaml
Outdated
| run: ci/scripts/test.sh $(pwd) | ||
|
|
||
| integration: | ||
| name: AMD64 integration |
Member
There was a problem hiding this comment.
I am wondering whether AMD64 is relevant at the moment, I just feel it visually clutters the jobs and makes it slightly more difficult to find what I am looking for:
We use uppercase on apache/arrow-go (AMD64 Conda Integration) and apache/arrow (Integration / AMD64 Conda Integration Test). We use lowercase on apache/arrow-java. I prefer uppercase, easier to read the important word
Suggested change
| name: AMD64 integration | |
| name: AMD64 Integration |
Member
Author
There was a problem hiding this comment.
Good point! I'll remove "AMD64" from all job names, change "integration" to "Integration" and merge this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11.