Restore accidentally removed method Block::to_ne_bytes #8211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method was removed in apache#7824, which introduced an optimized code path for writing bloom filters on little-endian architectures. The method was however still used in the big-endian code-path. Due to the use of `#[cfg(target_endian)]` this went unnoticed in CI. Fixes apache#8207
|
FYI @kylebarron I wonder if there is any way to add a test to our CI. Given we don't have any big endian runners i suspect someone who is interested in supporting big endian would likely need to help volunteer to test it |
|
Thanks @jhorstmann and @etseidl |
|
I think maybe we could test / prevent regressions by using rust's cross compiler to verify building on s390. I remembered this when we hit some problem building wheels downstream: https://github.com/clflushopt/tpchgen-rs/actions/runs/17256139341/job/48969309163 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method was removed in #7824, which introduced an optimized code path for writing bloom filters on little-endian architectures. The method was however still used in the big-endian code-path. Due to the use of
#[cfg(target_endian)]this went unnoticed in CI.Fixes #8207