fix: deserializing ignored enum #15
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue description
Ignored enum values cause a deserialization error when using the
from_valuefunction.How to reproduce
This code produces an error saying
incorrect value of type: Enum:Proposal
I see the
deserialize_anyfunction is basically called only fromdeserialize_ignored_any.I might have also made a wrong assumption, but it seems unlikely that
from_valuewill be used to deserialize into a type that itsDeserializeimplementation callsdeserialize_any, as theValuepassed as a parameter already represents an arbitrary Avro value. For that reason I opted to call thevisit_borrowed_stron thevisitorwhen finding aValue::Enuminsidedeserialize_any, avoiding allocating further memory. I would appreciate any further insight on this though, as I'm not sure if it's the right approach.