Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

claudevdm
Copy link
Collaborator

@claudevdm claudevdm commented Dec 18, 2024

Add ingestion and enrichment components for rag pipelines.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@claudevdm claudevdm force-pushed the add-rag-ingestion-enrichment branch 2 times, most recently from e50d908 to e966cb7 Compare December 19, 2024 01:10
@github-actions github-actions bot added the build label Dec 19, 2024
@claudevdm claudevdm force-pushed the add-rag-ingestion-enrichment branch 6 times, most recently from ba5ef2a to b759659 Compare December 19, 2024 17:41
@claudevdm claudevdm force-pushed the add-rag-ingestion-enrichment branch from b759659 to b2ad7ac Compare December 19, 2024 20:57
@claudevdm
Copy link
Collaborator Author

R: @damccorm

@claudevdm claudevdm marked this pull request as ready for review December 19, 2024 21:02
@claudevdm claudevdm force-pushed the add-rag-ingestion-enrichment branch from b2ad7ac to 589023f Compare December 19, 2024 21:03
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Comments are all minor, I'm really excited with how this turned out!

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 81.48148% with 25 lines in your changes missing coverage. Please review.

Project coverage is 59.05%. Comparing base (18ec331) to head (6f07040).

Files with missing lines Patch % Lines
...ks/python/apache_beam/ml/rag/ingestion/bigquery.py 64.86% 13 Missing ⚠️
...e_beam/ml/rag/enrichment/bigquery_vector_search.py 86.07% 11 Missing ⚠️
sdks/python/apache_beam/ml/rag/ingestion/base.py 94.11% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #33413      +/-   ##
============================================
+ Coverage     59.02%   59.05%   +0.02%     
  Complexity     3185     3185              
============================================
  Files          1146     1149       +3     
  Lines        176085   176219     +134     
  Branches       3368     3368              
============================================
+ Hits         103942   104073     +131     
- Misses        68787    68790       +3     
  Partials       3356     3356              
Flag Coverage Δ
python 81.26% <81.48%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more nit, otherwise LGTM

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@damccorm damccorm merged commit bc44583 into apache:master Jan 14, 2025
86 of 90 checks passed
VardhanThigle pushed a commit to VardhanThigle/beam that referenced this pull request Mar 21, 2025
* Add base VectorDatabaseTransform.

* Add BigQueryVectorWriterConfig.

* Add BigQueryVectorWriterConfig tests.

* Allow overriding joinfn and custom types from EnrichmentSourceHandler.

* Add BigQueryVectorSearchEnrichmentHandler.

* Fix streaming test.

* Add licence.

* Fix project in vector search test and pydocs.

* Fix bigquery streaming test.

* Resolve open comments. Also fix batching logic when metadata restrictions are applied.

* Resolve comments.

* Fix bigquery ingestion default schema to work with Avro file loads.

* Assert that embedding set in vector write

* Call out RAG changes in CHANGES.md.

* Add PR links to CHANGES.md.

---------

Co-authored-by: Claude <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants