[Managed Iceberg] Fix partition value race condition #33549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
kennknowles
approved these changes
Jan 9, 2025
| routingPartitionKey.partition(getPartitionableRecord(record)); | ||
|
|
||
| if (!writers.asMap().containsKey(partitionKey) && openWriters >= maxNumWriters) { | ||
| if (!writers.asMap().containsKey(routingPartitionKey) && openWriters >= maxNumWriters) { |
There was a problem hiding this comment.
nit: You aren't guaranteed that asMap is cheap. It could be linear time to convert from some other underlying data structure. It is better to call get and check if the result was null. (since this is not a LoadingCache you don't have to worry about accidentally creating too many entries)
(maybe think about it for future changes)
There was a problem hiding this comment.
Thanks for the tip, will do
|
Assigning reviewers. If you would like to opt out of this review, comment R: @damondouglas for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
ahmedabu98
added a commit
to ahmedabu98/beam
that referenced
this pull request
Jan 9, 2025
* fix and update tests * dont mention df yet * add PR link * whitespace
ahmedabu98
added a commit
to ahmedabu98/beam
that referenced
this pull request
Jan 9, 2025
* fix and update tests * dont mention df yet * add PR link * whitespace
kennknowles
pushed a commit
that referenced
this pull request
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33497 (see comment and comment for details)
Also updates tests