Support custom coders in Reshuffle #33932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…shuffle" This reverts commit 4cbf257.
… typehint behavior.
|
r: @robertwb |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
|
Run Python_Dataframes PreCommit 3.10 |
Thanks for reviewing, @robertwb! |
|
Run Python_ML PreCommit 3.12 |
|
beam_PreCommit_Python_ML is very long. Merging it anyways since 2/4 Python version passed. Consider move some tests to PostCommit and/or run on only 3.9+3.12 |
VardhanThigle
pushed a commit
to VardhanThigle/beam
that referenced
this pull request
Mar 21, 2025
* Revert "Revert three commits related to supporting custom coder in reshuffle" This reverts commit 4cbf257. * Use update_compatibility_version flag to determine whether to use new typehint behavior. * Highlight changes in CHANGES.md * Minor refactoring based on feedback. * Fix lints. * Simply the documented breaking changes. * Fix typo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update_compatibility_versionflag to determine whether to change back to the previous behavior. (A suggestion from Revert three commits related to supporting custom coder in reshuffle #33414 (comment))fixes #29908
fixes #33356