[IcebergIO] Filter out data files that have already been committed #34264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmedabu98
commented
Mar 12, 2025
| // TODO(ahmedabu98): This does not cover concurrent writes from other pipelines, where the | ||
| // "last successful snapshot" might reflect commits from other sources. Ideally, we would make | ||
| // this stateful, but that is update incompatible. | ||
| // TODO(ahmedabu98): add load test pipelines with intentional periodic crashing |
There was a problem hiding this comment.
Not feasible to have a meaningful test for this without Dataflow
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
assign set of reviewers |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @robertwb for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
damccorm
reviewed
Mar 13, 2025
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/AppendFilesToTables.java
Outdated
Show resolved
Hide resolved
damccorm
approved these changes
Mar 20, 2025
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/AppendFilesToTables.java
Outdated
Show resolved
Hide resolved
talatuyarer
pushed a commit
to talatuyarer/beam
that referenced
this pull request
Mar 20, 2025
…pache#34264) * remove already committed files * changes * simplify validation * validate without loading the whole collection into memory
prodriguezdefino
pushed a commit
to prodriguezdefino/beam-pabs
that referenced
this pull request
Mar 26, 2025
…pache#34264) * remove already committed files * changes * simplify validation * validate without loading the whole collection into memory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the sink more resilient to bundle retries.
Fixes #34074