-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Update pypi documentation 30145 #34329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pypi documentation 30145 #34329
Conversation
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
sdks/python/README.md
Outdated
|
||
|
||
Instructions for building and testing Beam itself | ||
are in the [contribution guide](./CONTRIBUTING.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this md link work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, this will not work. I need to adjust the path.
Thanks a lot! Left some comments. |
@liferoad do we have any shortcut to re-run the failed test tasks? |
https://github.com/apache/beam/blob/master/.github/workflows/README.md#running-workflows-manually or using trigger commands: |
Run Prism_Python PreCommit 3.9 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #34329 +/- ##
============================================
+ Coverage 56.34% 56.53% +0.19%
Complexity 3286 3286
============================================
Files 1173 1182 +9
Lines 179037 181076 +2039
Branches 3398 3398
============================================
+ Hits 100877 102375 +1498
- Misses 74903 75444 +541
Partials 3257 3257
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Assigning reviewers. If you would like to opt out of this review, comment R: @tvalentyn for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Run Yaml_Xlang_Direct PreCommit |
Run Python_Coverage PreCommit |
Run Python_ML PreCommit 3.12 |
Run Python_ML PreCommit 3.9 |
Run Python_ML PreCommit 3.11 |
Run Python_ML PreCommit 3.10 |
ec25727
to
71b53cf
Compare
71b53cf
to
e2c3b36
Compare
sdks/python/README.md
Outdated
|
||
## Python streaming pipelines | ||
|
||
Python [streaming pipeline execution](/documentation/sdks/python-streaming) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should use the full url paths.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@liferoad are you noticing any error log that is complaining about the relative path?
I have been trying to find the logs from the CI/CD but I am not able to find it.
Is there any documentation that can help replicate this on my local machine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean this will be added here: https://pypi.org/project/apache-beam/. So only full paths can work, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@liferoad I thought the setup tool will automatically figure that out based on this config and generate the the righgt link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure. I checked https://github.com/numpy/numpy/blob/main/README.md?plain=1, which looks like using the full url paths.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will update the document and provide the full path.
Is there way to check the generated files in CI/CD environment to make sure that it has generated the right formatted file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not know since this is part of Beam release steps to PyPi.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to using the full links. I'm not confident that the relative paths will definitely work, and it seems safer to use full links.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually validated that these don't get replaced, in the final text I see - Python [streaming pipeline execution](/documentation/sdks/python-streaming)
Steps I followed:
- Wheels are automatically generated when we build wheels. First from this PRs checks, I clicked one of the build wheels steps
- I went to summary, scrolled down to the bottom, and downloaded a set of wheels (I chose wheelhouse-cp312-macos-13, but I don't think this matters)
- Extract the wheels from downloads with mac's archive extracter. These are just fancy zip files - https://stackoverflow.com/questions/32923952/how-do-i-list-the-files-inside-a-python-wheel
- Navigated to
apache_beam-2.66.0.dev0.dist-info/METADATA
. This has the content that will be rendered in the pydoc I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@damccorm thank you for testing that out. I will change the link to the full link.
Reminder, please take a look at this pr: @tvalentyn |
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @damccorm for label python. Available commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - this looks like a good step, I think we can merge once the outstanding comment about paths is addressed
sdks/python/README.md
Outdated
|
||
## Python streaming pipelines | ||
|
||
Python [streaming pipeline execution](/documentation/sdks/python-streaming) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to using the full links. I'm not confident that the relative paths will definitely work, and it seems safer to use full links.
sdks/python/README.md
Outdated
|
||
## Python streaming pipelines | ||
|
||
Python [streaming pipeline execution](/documentation/sdks/python-streaming) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually validated that these don't get replaced, in the final text I see - Python [streaming pipeline execution](/documentation/sdks/python-streaming)
Steps I followed:
- Wheels are automatically generated when we build wheels. First from this PRs checks, I clicked one of the build wheels steps
- I went to summary, scrolled down to the bottom, and downloaded a set of wheels (I chose wheelhouse-cp312-macos-13, but I don't think this matters)
- Extract the wheels from downloads with mac's archive extracter. These are just fancy zip files - https://stackoverflow.com/questions/32923952/how-do-i-list-the-files-inside-a-python-wheel
- Navigated to
apache_beam-2.66.0.dev0.dist-info/METADATA
. This has the content that will be rendered in the pydoc I think.
@damccorm I have taken care of the comments and I am waiting for test to pass. |
#35211 tracks one of the failed workflows. |
Re-triggered some workflows. |
Please add a meaningful description for your change here
#30145
Added Pypi friendly documentation for Python SDK.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.