Add glob and single file support to BeamSQL ParquetTable LOCATION #35582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Assigning reviewers: R: @chamikaramj for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Abacn
reviewed
Jul 14, 2025
...sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/parquet/ParquetTable.java
Outdated
Show resolved
Hide resolved
…and documenration
Abacn
reviewed
Jul 14, 2025
...sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/parquet/ParquetTable.java
Show resolved
Hide resolved
talatuyarer
added a commit
to talatuyarer/beam
that referenced
this pull request
Jul 15, 2025
…ache#35582) * Add glob and single file support to ParquetTable LOCATION * not rely on FileSystems.match call to resolveFilePattern. Added test and documenration * CHANGES.md update for behaviour change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies ParquetTable to intelligently resolve the file path before passing it to ParquetIO.
It uses FileSystems.match() to check if the provided LOCATION corresponds to a directory.
If it's a directory, a wildcard (*) is appended to the path to maintain the existing behavior of reading all files within it.
If it's not a directory (i.e., it's a file or a path that doesn't exist yet), it's treated as a user-provided pattern (either a glob or a single file path) and is used as-is.
fixes #20884
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.