Add ThrottlingSignaler class to the Java SDK #36119
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @jrmccluskey, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new utility class in the Java SDK aimed at standardizing how I/O operations communicate throttling events to the Apache Beam runner. The primary purpose is to prevent aggressive autoscaling when a process is intentionally slowing down due to external factors like rate limits or quotas from remote services. This change provides a cleaner, more abstract interface for managing and signaling such conditions.
Highlights
- New Class Introduction: Introduces the ThrottlingSignaler class to the Java SDK, providing a standardized way for IOs to signal to the runner that a remote call is being throttled.
- Abstraction of Throttling Mechanism: This new class abstracts the underlying counter method used for throttling, making it easier to replace or modify the throttling mechanism in the future without affecting user-facing code.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
@gemini-code-assist review |
There was a problem hiding this comment.
Code Review
This pull request introduces a ThrottlingSignaler class to abstract the mechanism for signaling throttling to the runner. The implementation has a critical compilation error in one of its constructors and a deviation from standard Java naming conventions. I've provided a suggestion to fix these issues and improve the code by making the counter field final.
...omponents/src/main/java/org/apache/beam/sdk/io/components/throttling/ThrottlingSignaler.java
Outdated
Show resolved
Hide resolved
…omponents/throttling/ThrottlingSignaler.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
Assigning reviewers: R: @ahmedabu98 for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Reminder, please take a look at this pr: @ahmedabu98 |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @robertwb for label java. Available commands:
|
|
Reminder, please take a look at this pr: @robertwb |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @ahmedabu98 for label java. Available commands:
|
| } | ||
|
|
||
| public ThrottlingSignaler() { | ||
| this(""); |
There was a problem hiding this comment.
Should we use
as the default namespace?There was a problem hiding this comment.
that's reasonable, done
Adds a class for the worker to signal to the runner that a remote call is being throttled. This abstracts the current counter method away from the user such that it can be replaced in the future.
Java version of #35984
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.