Make Beartype use the default behavior in is_consistent_with()#38275
Make Beartype use the default behavior in is_consistent_with()#38275jrmccluskey wants to merge 6 commits intoapache:masterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Apache Beam Python SDK to make Beartype the default behavior for type consistency checks. It provides a mechanism to disable this behavior via a new pipeline option, ensuring backward compatibility and flexibility for users who may need to opt-out of this specific type checking implementation. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
@gemini-code-assist review |
There was a problem hiding this comment.
Code Review
This pull request establishes Beartype as the default fallback type checking tool for the Python SDK and introduces a --disable_beartype pipeline option. The review feedback suggests moving the changelog entry to the Breaking Changes section to better reflect its impact on existing pipelines. Additionally, the lru_cache on the _is_beartype_disabled helper should be removed because PipelineOptions are mutable, which could lead to incorrect cached values, and the functools import should be cleaned up accordingly.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
Assigning reviewers: R: @shunping for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Makes using Beartype as the fallback type check the default behavior. This can be disabled using the new
--disable_beartypepipeline option, accessed in the typehinting infrastructure via the globally available get_pipeline_options() function.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.