[CALCITE-7778] JDBC adapter for MSSQL generates % for MOD without preserving grouping, giving wrong results - #5259
Open
wasabii wants to merge 2 commits into
Open
Conversation
…serving grouping, giving wrong results
|
mihaibudiu
reviewed
Sep 12, 2026
| * operator before the dialect is consulted, so an operator that binds less | ||
| * tightly needs them added here. | ||
| */ | ||
| public static void unparseWithOperator(SqlWriter writer, SqlOperator operator, |
Contributor
There was a problem hiding this comment.
maybe this should be called "unparseWithBinaryOperator"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Link
CALCITE-7778
Changes Proposed
Parenthesize the
%written forMODwhere its lower precedence requires it. Shared inRelToSqlConverterUtilrather than the dialect, sinceHiveSqlDialectmakes the same substitution and somebody might want to fix that also some day.