[UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume #10265

sureshanaparti · 2025-01-24T10:57:56Z

Description

This PR allows quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume, addresses #10106.

Also, updated snapshot forms to show quiescevm for VMware & KVM hypervisors.

Changes from ui/src/views/storage/TakeSnapshot.vue were removed in #7873, re-added in this PR. Now, ui/src/views/compute/CreateSnapshotWizard.vue and ui/src/views/storage/TakeSnapshot.vue are in sync with respect to quiescevm and asyncbackup flags.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Checked the create snapshot UI from instance and volume.

How did you try to break this feature and the system with this change?

sureshanaparti · 2025-01-24T10:59:09Z

@blueorangutan ui

blueorangutan · 2025-01-24T11:00:03Z

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

codecov · 2025-01-24T11:05:42Z

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 15.17%. Comparing base (f055268) to head (f2f2c7b).
Report is 12 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
.../storage/vmsnapshot/StorageVMSnapshotStrategy.java	85.71%	0 Missing and 1 partial ⚠️
...om/cloud/storage/snapshot/SnapshotManagerImpl.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.19   #10265   +/-   ##
=========================================
  Coverage     15.16%   15.17%           
- Complexity    11332    11333    +1     
=========================================
  Files          5415     5415           
  Lines        474912   474938   +26     
  Branches      57926    57930    +4     
=========================================
+ Hits          72043    72057   +14     
- Misses       394814   394823    +9     
- Partials       8055     8058    +3

Flag	Coverage Δ
uitests	`4.28% <ø> (-0.01%)`	⬇️
unittests	`15.89% <75.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

blueorangutan · 2025-01-24T11:17:14Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10265 (QA-JID-531)

DaanHoogland

clgtm

DaanHoogland · 2025-01-24T12:09:17Z

@Rubueno , any chance you can test this?

Rubueno · 2025-01-24T12:30:21Z

@Rubueno , any chance you can test this?

Thanks for your efforts @DaanHoogland ! I'm abroad right now, but I'll try to find time next week.

DaanHoogland · 2025-01-24T12:56:29Z

@Rubueno , any chance you can test this?

Thanks for your efforts @DaanHoogland ! I'm abroad right now, but I'll try to find time next week.

have a good trip @Rubueno , I hope to start on a release by the end of next week, no pressure ;)

Rubueno · 2025-01-27T11:55:18Z

@Rubueno , any chance you can test this?

Thanks for your efforts @DaanHoogland ! I'm abroad right now, but I'll try to find time next week.

have a good trip @Rubueno , I hope to start on a release by the end of next week, no pressure ;)

Thanks! I've just tested the change but it does not seem the quiesce option is present in the "Take Instance volume Snapshot" window. I've tested with local, RBD and NFS on KVM.

DaanHoogland · 2025-01-27T12:49:49Z

Thanks! I've just tested the change but it does not seem the quiesce option is present in the "Take Instance volume Snapshot" window. I've tested with local, RBD and NFS on KVM.

You are right, I only see it on the take instance snapshot dialog. Can you comment @sureshanaparti ?

sureshanaparti · 2025-01-29T10:02:46Z

Thanks! I've just tested the change but it does not seem the quiesce option is present in the "Take Instance volume Snapshot" window. I've tested with local, RBD and NFS on KVM.

You are right, I only see it on the take instance snapshot dialog. Can you comment @sureshanaparti ?

quiesce option will not available in both VM -> "Take Instance volume Snapshot" & Volume -> "Take Snapshot" dialogs, when the volume response returns quiescevm as false.

Rubueno · 2025-01-29T10:22:31Z

Thanks! I've just tested the change but it does not seem the quiesce option is present in the "Take Instance volume Snapshot" window. I've tested with local, RBD and NFS on KVM.

You are right, I only see it on the take instance snapshot dialog. Can you comment @sureshanaparti ?

quiesce option will not available in both VM -> "Take Instance volume Snapshot" & Volume -> "Take Snapshot" dialogs, when the volume response returns quiescevm as false.

But in this case it is present in Volume -> "Take Snapshot" and VM -> "Take Instance Snapshot" dialogs

sureshanaparti · 2025-01-30T07:45:29Z

Thanks! I've just tested the change but it does not seem the quiesce option is present in the "Take Instance volume Snapshot" window. I've tested with local, RBD and NFS on KVM.

You are right, I only see it on the take instance snapshot dialog. Can you comment @sureshanaparti ?

quiesce option will not available in both VM -> "Take Instance volume Snapshot" & Volume -> "Take Snapshot" dialogs, when the volume response returns quiescevm as false.

But in this case it is present in Volume -> "Take Snapshot" and VM -> "Take Instance Snapshot" dialogs

Both these dialogs are in sync with the quiescevm param in the volume response, shows it when quiescevm param is true.

Even when it is set, it fails here when unsupported: https://github.com/apache/cloudstack/blob/4.19/engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/snapshot/DefaultSnapshotStrategy.java#L496-L498

sureshanaparti · 2025-02-03T08:48:41Z

@Rubueno are you fine with these changes in this PR (both dialogs are in sync with respect to the volume response).

ui/src/views/compute/CreateSnapshotWizard.vue (VM -> "Take Instance volume Snapshot" dialog) =>

        <a-form-item name="quiescevm" ref="quiescevm" v-if="isQuiesceVm">
          <template #label>
            <tooltip-label :title="$t('label.quiescevm')" :tooltip="apiParams.quiescevm.description"/>
          </template>
          <a-switch v-model:checked="form.quiescevm"/>
        </a-form-item>
        <a-form-item name="asyncbackup" ref="asyncbackup" v-if="!supportsStorageSnapshot">
          <template #label>
            <tooltip-label :title="$t('label.asyncbackup')" :tooltip="apiParams.asyncbackup.description"/>
          </template>
          <a-switch v-model:checked="form.asyncbackup"/>
        </a-form-item>

ui/src/views/storage/TakeSnapshot.vue (Volume -> "Take Snapshot" dialog) =>

        <a-form-item :label="$t('label.asyncbackup')" name="asyncbackup" ref="asyncbackup" v-if="!supportsStorageSnapshot">
          <a-switch v-model:checked="form.asyncbackup" />
        </a-form-item>
        <a-form-item :label="$t('label.quiescevm')" name="quiescevm" ref="quiescevm" v-if="quiescevm">
          <a-switch v-model:checked="form.quiescevm" />
        </a-form-item>

Rubueno · 2025-02-03T08:51:05Z

@sureshanaparti In our env I cannot proceed with testing this, and thus does not resolve issue #10106, as both dialog boxes give different output at the moment

sureshanaparti · 2025-02-03T10:21:13Z

@sureshanaparti In our env I cannot proceed with testing this, and thus does not resolve issue #10106, as both dialog boxes give different output at the moment

ok @Rubueno, does your env has the updated code / pkgs from this PR?

sureshanaparti · 2025-02-03T10:21:35Z

@blueorangutan package

blueorangutan · 2025-02-03T10:22:03Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Rubueno · 2025-02-03T10:22:49Z

Yes I had built new packages based on 4.19

blueorangutan · 2025-02-03T11:40:27Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12308

Rubueno · 2025-02-03T11:59:35Z

Hmm an interesting development: When taking a snapshot from VM -> "Take Instance Snapshot" with "Quiesce Instance" enabled, it will make a snapshot and quiesce process works. When taking a snapshot from Volume -> "Take Snapshot" with "Quiesce Instance" enabled, it will not quiesce the instance and even logs "quiesceVm":false

VM -> "Take Instance Snapshot" logfile: https://pastebin.com/hYMHDxKF
Volume -> "Take Snapshot" logfile: https://pastebin.com/EF33nP6z

DaanHoogland · 2025-03-06T15:15:55Z

@sureshanaparti can you comment on @Rubueno 's results?

blueorangutan · 2025-04-21T10:13:48Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13120

sureshanaparti · 2025-04-21T14:25:38Z

Hmm an interesting development: When taking a snapshot from VM -> "Take Instance Snapshot" with "Quiesce Instance" enabled, it will make a snapshot and quiesce process works. When taking a snapshot from Volume -> "Take Snapshot" with "Quiesce Instance" enabled, it will not quiesce the instance and even logs "quiesceVm":false

VM -> "Take Instance Snapshot" logfile: https://pastebin.com/hYMHDxKF Volume -> "Take Snapshot" logfile: https://pastebin.com/EF33nP6z

@Rubueno Fixed to set quiescevm in the snapshot payload (from the quiescevm parameter) while taking a snapshot from volume, please check.

sureshanaparti · 2025-04-21T15:07:39Z

I've done some review/testing and discussed with Suresh, following are the findings.

There are 3 forms where we are using "quiescevm"

For a stopped VM - "Take Instance volume Snapshot"

For a volume - "Take Snapshot"

For a running VM - "Take Instance Snapshot"

For 1 and 2, as @sureshanaparti said it is controlled by "quiescevm" param in the volume response. I see that it has made it consistent with this PR. Though there is another bug like @Rubueno mentioned, the value of "quiescevm" is not honored in the API.

For 3, "Take Instance Snapshot" "quiescevm" is there by default. May be we can check for which hypervisors it is supported and keep only for those.

@harikrishna-patnala thanks for testing, I've verified "quiescevm" for all the 3 forms, it is honored as set in the UI. Changes done for "quiescevm" in "Take Instance Snapshot" form to show for VMware, KVM hypervisors only - it is used for VMware, the support of it depends on the underlying storage for KVM, ignored/unused for XenServer.

sureshanaparti · 2025-04-21T15:07:53Z

@blueorangutan package

blueorangutan · 2025-04-21T15:08:04Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-04-21T15:22:16Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 13122

Rubueno · 2025-04-21T15:30:04Z

I've done some review/testing and discussed with Suresh, following are the findings.
There are 3 forms where we are using "quiescevm"

For a stopped VM - "Take Instance volume Snapshot"

For a volume - "Take Snapshot"

For a running VM - "Take Instance Snapshot"

For 1 and 2, as @sureshanaparti said it is controlled by "quiescevm" param in the volume response. I see that it has made it consistent with this PR. Though there is another bug like @Rubueno mentioned, the value of "quiescevm" is not honored in the API.
For 3, "Take Instance Snapshot" "quiescevm" is there by default. May be we can check for which hypervisors it is supported and keep only for those.

@harikrishna-patnala thanks for testing, I've verified "quiescevm" for all the 3 forms, it is honored as set in the UI. Changes done for "quiescevm" in "Take Instance Snapshot" form to show for VMware, KVM hypervisors only - it is used for VMware, the support of it depends on the underlying storage for KVM, ignored/unused for XenServer.

Thank you both for your efforts. I'm traveling right now and unable to test myself.

sureshanaparti · 2025-04-22T09:09:50Z

@blueorangutan package

blueorangutan · 2025-04-22T09:12:04Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-04-22T10:25:48Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13131

sureshanaparti · 2025-04-22T12:57:45Z

Noticed below issues in the Simulator CI tests, seems to be python (version) issue. cc @DaanHoogland

2025-04-22 12:23:28,676 - DEBUG - ::::::::::::STARTED : TC: Failure: :::::::::::

2025-04-22 12:23:28,677 - CRITICAL - EXCEPTION: Failure:: ['Traceback (most recent call last):\n', '  File "/opt/hostedtoolcache/Python/3.10.17/x64/lib/python3.10/unittest/case.py", line 59, in testPartExecutor\n    yield\n', '  File "/opt/hostedtoolcache/Python/3.10.17/x64/lib/python3.10/unittest/case.py", line 591, in run\n    self._callTestMethod(testMethod)\n', '  File "/opt/hostedtoolcache/Python/3.10.17/x64/lib/python3.10/unittest/case.py", line 549, in _callTestMethod\n    method()\n', '  File "/home/runner/.local/lib/python3.10/site-packages/nose/failure.py", line 35, in runTest\n    raise self.exc_val.with_traceback(self.tb)\n', '  File "/home/runner/.local/lib/python3.10/site-packages/nose/loader.py", line 335, in loadTestsFromName\n    module = self.importer.importFromPath(\n', '  File "/home/runner/.local/lib/python3.10/site-packages/nose/importer.py", line 162, in importFromPath\n    return self.importFromDir(dir_path, fqname)\n', '  File "/home/runner/.local/lib/python3.10/site-packages/nose/importer.py", line 198, in importFromDir\n    mod = load_module(part_fqname, fh, filename, desc)\n', '  File "/home/runner/.local/lib/python3.10/site-packages/nose/importer.py", line 128, in load_module\n    spec.loader.exec_module(mod)\n', '  File "<frozen importlib._bootstrap_external>", line 883, in exec_module\n', '  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed\n', '  File "/home/runner/work/cloudstack/cloudstack/test/integration/smoke/test_certauthority_root.py", line 27, in <module>\n    from OpenSSL.crypto import FILETYPE_PEM, verify, X509\n', "ImportError: cannot import name 'verify' from 'OpenSSL.crypto' (unknown location)\n"]

2025-04-22 12:23:28,678 - DEBUG - TestCaseName: Failure:; Time Taken: 0 Seconds; StartTime: Tue Apr 22 12:23:28 2025; EndTime: Tue Apr 22 12:23:28 2025; Result: EXCEPTION

Exception occurred during processing of request from ('127.0.0.1', 55687)

Traceback (most recent call last):

  File "/opt/hostedtoolcache/Python/3.10.17/x64/lib/python3.10/socketserver.py", line 683, in process_request_thread

    self.finish_request(request, client_address)

  File "/opt/hostedtoolcache/Python/3.10.17/x64/lib/python3.10/socketserver.py", line 360, in finish_request

    self.RequestHandlerClass(request, client_address, self)

  File "/opt/hostedtoolcache/Python/3.10.17/x64/lib/python3.10/socketserver.py", line 747, in __init__

    self.handle()

  File "/home/runner/.local/lib/python3.10/site-packages/ipmisim/ipmisim.py", line 443, in handle

    return IpmiServerContext().handle(data, address, socket)

  File "/home/runner/.local/lib/python3.10/site-packages/ipmisim/ipmisim.py", line 125, in handle

    self._got_request(data, address, self.session)

  File "/home/runner/.local/lib/python3.10/site-packages/ipmisim/ipmisim.py", line 222, in _got_request

    session._ipmi20(data)

  File "/home/runner/.local/lib/python3.10/site-packages/ipmisim/fakesession.py", line 127, in _ipmi20

    decrypter = AES.new(self.aeskey, AES.MODE_CBC, iv)

  File "/home/runner/.local/lib/python3.10/site-packages/Crypto/Cipher/AES.py", line 95, in new

    return AESCipher(key, *args, **kwargs)

  File "/home/runner/.local/lib/python3.10/site-packages/Crypto/Cipher/AES.py", line 59, in __init__

    blockalgo.BlockAlgo.__init__(self, _AES, key, *args, **kwargs)

  File "/home/runner/.local/lib/python3.10/site-packages/Crypto/Cipher/blockalgo.py", line 141, in __init__

    self._cipher = factory.new(key, *args, **kwargs)

SystemError: PY_SSIZE_T_CLEAN macro must be defined for '#' formats

sureshanaparti · 2025-04-22T12:58:04Z

@blueorangutan test

blueorangutan · 2025-04-22T13:00:04Z

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

weizhouapache · 2025-04-22T13:00:38Z

Noticed below issues in the Simulator CI tests, seems to be python (version) issue. cc @DaanHoogland

2025-04-22 12:23:28,676 - DEBUG - ::::::::::::STARTED : TC: Failure: :::::::::::

2025-04-22 12:23:28,677 - CRITICAL - EXCEPTION: Failure:: ['Traceback (most recent call last):\n', '  File "/opt/hostedtoolcache/Python/3.10.17/x64/lib/python3.10/unittest/case.py", line 59, in testPartExecutor\n    yield\n', '  File "/opt/hostedtoolcache/Python/3.10.17/x64/lib/python3.10/unittest/case.py", line 591, in run\n    self._callTestMethod(testMethod)\n', '  File "/opt/hostedtoolcache/Python/3.10.17/x64/lib/python3.10/unittest/case.py", line 549, in _callTestMethod\n    method()\n', '  File "/home/runner/.local/lib/python3.10/site-packages/nose/failure.py", line 35, in runTest\n    raise self.exc_val.with_traceback(self.tb)\n', '  File "/home/runner/.local/lib/python3.10/site-packages/nose/loader.py", line 335, in loadTestsFromName\n    module = self.importer.importFromPath(\n', '  File "/home/runner/.local/lib/python3.10/site-packages/nose/importer.py", line 162, in importFromPath\n    return self.importFromDir(dir_path, fqname)\n', '  File "/home/runner/.local/lib/python3.10/site-packages/nose/importer.py", line 198, in importFromDir\n    mod = load_module(part_fqname, fh, filename, desc)\n', '  File "/home/runner/.local/lib/python3.10/site-packages/nose/importer.py", line 128, in load_module\n    spec.loader.exec_module(mod)\n', '  File "<frozen importlib._bootstrap_external>", line 883, in exec_module\n', '  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed\n', '  File "/home/runner/work/cloudstack/cloudstack/test/integration/smoke/test_certauthority_root.py", line 27, in <module>\n    from OpenSSL.crypto import FILETYPE_PEM, verify, X509\n', "ImportError: cannot import name 'verify' from 'OpenSSL.crypto' (unknown location)\n"]

2025-04-22 12:23:28,678 - DEBUG - TestCaseName: Failure:; Time Taken: 0 Seconds; StartTime: Tue Apr 22 12:23:28 2025; EndTime: Tue Apr 22 12:23:28 2025; Result: EXCEPTION

Exception occurred during processing of request from ('127.0.0.1', 55687)

Traceback (most recent call last):

  File "/opt/hostedtoolcache/Python/3.10.17/x64/lib/python3.10/socketserver.py", line 683, in process_request_thread

    self.finish_request(request, client_address)

  File "/opt/hostedtoolcache/Python/3.10.17/x64/lib/python3.10/socketserver.py", line 360, in finish_request

    self.RequestHandlerClass(request, client_address, self)

  File "/opt/hostedtoolcache/Python/3.10.17/x64/lib/python3.10/socketserver.py", line 747, in __init__

    self.handle()

  File "/home/runner/.local/lib/python3.10/site-packages/ipmisim/ipmisim.py", line 443, in handle

    return IpmiServerContext().handle(data, address, socket)

  File "/home/runner/.local/lib/python3.10/site-packages/ipmisim/ipmisim.py", line 125, in handle

    self._got_request(data, address, self.session)

  File "/home/runner/.local/lib/python3.10/site-packages/ipmisim/ipmisim.py", line 222, in _got_request

    session._ipmi20(data)

  File "/home/runner/.local/lib/python3.10/site-packages/ipmisim/fakesession.py", line 127, in _ipmi20

    decrypter = AES.new(self.aeskey, AES.MODE_CBC, iv)

  File "/home/runner/.local/lib/python3.10/site-packages/Crypto/Cipher/AES.py", line 95, in new

    return AESCipher(key, *args, **kwargs)

  File "/home/runner/.local/lib/python3.10/site-packages/Crypto/Cipher/AES.py", line 59, in __init__

    blockalgo.BlockAlgo.__init__(self, _AES, key, *args, **kwargs)

  File "/home/runner/.local/lib/python3.10/site-packages/Crypto/Cipher/blockalgo.py", line 141, in __init__

    self._cipher = factory.new(key, *args, **kwargs)

SystemError: PY_SSIZE_T_CLEAN macro must be defined for '#' formats

@sureshanaparti
refer to #10762

blueorangutan · 2025-04-23T05:29:29Z

[SF] Trillian test result (tid-13086)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 56548 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10265-t13086-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

...apshot/src/main/java/org/apache/cloudstack/storage/vmsnapshot/StorageVMSnapshotStrategy.java

DaanHoogland · 2025-05-01T13:06:45Z

@sureshanaparti , is it realistic to have this finished/fixed before 4.19.3?

sureshanaparti · 2025-05-02T06:32:17Z

@sureshanaparti , is it realistic to have this finished/fixed before 4.19.3?

@DaanHoogland no further changes required on this PR.

rosi-shapeblue

LGTM. The 'quiescevm' option is now displayed consistently in modals. If the volume response has 'quiescevm' enabled, only then you can see that option on both "Take Instance volume Snapshot" ( "Compute" -> "Instances") and "Take Snapshot" ("Volumes") UI.

boring-cyborg bot added the component:UI label Jan 24, 2025

sureshanaparti linked an issue Jan 24, 2025 that may be closed by this pull request

Quiesce Instance not an option in "Take Instance volume Snapshot" window #10106

Closed

sureshanaparti mentioned this pull request Jan 24, 2025

Quiesce Instance not an option in "Take Instance volume Snapshot" window #10106

Closed

sureshanaparti requested review from vishesh92 and DaanHoogland January 24, 2025 11:28

DaanHoogland added the status:needs-testing label Jan 24, 2025

DaanHoogland approved these changes Jan 24, 2025

View reviewed changes

sureshanaparti marked this pull request as ready for review January 29, 2025 10:03

Pearl1594 requested a review from harikrishna-patnala February 25, 2025 12:47

sureshanaparti added 2 commits April 21, 2025 19:38

quiescevm false when not set

f1c1568

update payload with quiescevm when set for vm snapshot

9675df5

boring-cyborg bot added the component:storage label Apr 21, 2025

sureshanaparti added this to the 4.19.3 milestone Apr 21, 2025

keep quiescevm for supported hypervisors (VMware, KVM) in ui

57126b7

sureshanaparti force-pushed the ui-volume-snapshot-quiescevm-sync branch from 2bbbfca to 57126b7 Compare April 21, 2025 15:20

unit test fix

f2f2c7b

harikrishna-patnala reviewed Apr 23, 2025

View reviewed changes

...apshot/src/main/java/org/apache/cloudstack/storage/vmsnapshot/StorageVMSnapshotStrategy.java Show resolved Hide resolved

rosi-shapeblue approved these changes May 2, 2025

View reviewed changes

rosi-shapeblue removed their assignment May 2, 2025

DaanHoogland removed the status:needs-testing label May 2, 2025

DaanHoogland merged commit 32cc45e into apache:4.19 May 2, 2025
23 of 26 checks passed

DaanHoogland deleted the ui-volume-snapshot-quiescevm-sync branch May 2, 2025 08:45

[UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume #10265

[UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume #10265

Conversation

sureshanaparti commented Jan 24, 2025 • edited Loading

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

sureshanaparti commented Jan 24, 2025

blueorangutan commented Jan 24, 2025

codecov bot commented Jan 24, 2025 • edited Loading

Codecov Report

blueorangutan commented Jan 24, 2025

DaanHoogland left a comment

Choose a reason for hiding this comment

DaanHoogland commented Jan 24, 2025

Rubueno commented Jan 24, 2025

DaanHoogland commented Jan 24, 2025

Rubueno commented Jan 27, 2025 • edited Loading

DaanHoogland commented Jan 27, 2025

sureshanaparti commented Jan 29, 2025

Rubueno commented Jan 29, 2025

sureshanaparti commented Jan 30, 2025 • edited Loading

sureshanaparti commented Feb 3, 2025 • edited Loading

Rubueno commented Feb 3, 2025

sureshanaparti commented Feb 3, 2025

sureshanaparti commented Feb 3, 2025

blueorangutan commented Feb 3, 2025

Rubueno commented Feb 3, 2025

blueorangutan commented Feb 3, 2025

Rubueno commented Feb 3, 2025

DaanHoogland commented Mar 6, 2025

blueorangutan commented Apr 21, 2025

sureshanaparti commented Apr 21, 2025

sureshanaparti commented Apr 21, 2025

sureshanaparti commented Apr 21, 2025

blueorangutan commented Apr 21, 2025

blueorangutan commented Apr 21, 2025

Rubueno commented Apr 21, 2025

sureshanaparti commented Apr 22, 2025

blueorangutan commented Apr 22, 2025

blueorangutan commented Apr 22, 2025

sureshanaparti commented Apr 22, 2025

sureshanaparti commented Apr 22, 2025

blueorangutan commented Apr 22, 2025

weizhouapache commented Apr 22, 2025

blueorangutan commented Apr 23, 2025

DaanHoogland commented May 1, 2025

sureshanaparti commented May 2, 2025 • edited Loading

rosi-shapeblue left a comment

Choose a reason for hiding this comment

sureshanaparti commented Jan 24, 2025 •

edited

Loading

codecov bot commented Jan 24, 2025 •

edited

Loading

Rubueno commented Jan 27, 2025 •

edited

Loading

sureshanaparti commented Jan 30, 2025 •

edited

Loading

sureshanaparti commented Feb 3, 2025 •

edited

Loading

sureshanaparti commented May 2, 2025 •

edited

Loading