api,ui: multi arch improvements #10289

shwstppr · 2025-01-28T11:59:45Z

Description

This PR adds the following changes concerning multi-arch support:

Allow downloading and seeing of aarch64 systemVM template for KVM
Improvements in deployments of system VMs including VRs to allow trying deployment with different architecture templates. Operator can now have their routing template with same name for different architectures and CloudStack will attempt deployment with all of them based on the below config. Similarly, now CloudStack will attempt to deploy SSVM and CPVM with different architecture templates available.
Configuring preferred system VM architecture for a zone using config - system.vm.preferred.architecture
UI changes to display, select and filter architecture fields for resources.
API and UI changes to allow filtering resources using arch - listCluster, listHosts, listVirtualMachines

Doc PR: apache/cloudstack-documentation#491

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov · 2025-01-28T12:07:24Z

Codecov Report

Attention: Patch coverage is 48.17073% with 425 lines in your changes missing coverage. Please review.

Project coverage is 16.12%. Comparing base (603cd84) to head (d8da081).
Report is 2 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
...om/cloud/upgrade/SystemVmTemplateRegistration.java	54.21%	114 Missing and 11 partials ⚠️
...om/cloud/consoleproxy/ConsoleProxyManagerImpl.java	28.57%	40 Missing ⚠️
.../network/lb/InternalLoadBalancerVMManagerImpl.java	45.16%	32 Missing and 2 partials ⚠️
...va/com/cloud/network/router/NetworkHelperImpl.java	32.65%	33 Missing ⚠️
...ain/java/com/cloud/storage/StorageManagerImpl.java	0.00%	32 Missing ⚠️
.../java/com/cloud/storage/dao/VMTemplateDaoImpl.java	72.97%	11 Missing and 9 partials ⚠️
.../secondarystorage/SecondaryStorageManagerImpl.java	42.85%	20 Missing ⚠️
...in/java/com/cloud/server/ManagementServerImpl.java	0.00%	12 Missing ⚠️
...ain/java/com/cloud/api/query/QueryManagerImpl.java	0.00%	10 Missing ⚠️
...dstack/storage/datastore/db/ImageStoreDaoImpl.java	0.00%	9 Missing ⚠️
... and 29 more

Additional details and impacted files

@@             Coverage Diff              @@
##               4.20   #10289      +/-   ##
============================================
+ Coverage     16.02%   16.12%   +0.10%     
- Complexity    13128    13211      +83     
============================================
  Files          5652     5652              
  Lines        496021   496467     +446     
  Branches      60065    60120      +55     
============================================
+ Hits          79488    80061     +573     
+ Misses       407665   407494     -171     
- Partials       8868     8912      +44

Flag	Coverage Δ
uitests	`4.00% <ø> (+<0.01%)`	⬆️
unittests	`16.97% <48.17%> (+0.10%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Abhishek Kumar <[email protected]>

blueorangutan · 2025-04-12T03:14:03Z

[SF] Trillian test result (tid-12954)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 67383 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10289-t12954-vmware-70u3.zip
Smoke tests completed. 134 look OK, 7 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_events_resource	`Error`	368.19	test_events_resource.py
ContextSuite context=TestClusterDRS>:setup	`Error`	0.00	test_cluster_drs.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80	`Error`	698.07	test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80	`Error`	871.69	test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces	`Error`	205.63	test_internal_lb.py
test_04_deploy_vm_for_other_user_and_test_vm_operations	`Error`	113.09	test_network_permissions.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup	`Error`	1523.38	test_network.py
test_02_restore_vm_with_disk_offering	`Error`	57.06	test_restore_vm.py
test_03_restore_vm_with_disk_offering_custom_size	`Error`	62.19	test_restore_vm.py
test_02_restore_vm_strict_tags_failure	`Error`	60.52	test_vm_strict_host_tags.py

Signed-off-by: Abhishek Kumar <[email protected]>

shwstppr · 2025-04-23T11:22:04Z

@blueorangutan package

blueorangutan · 2025-04-23T11:24:04Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-04-23T13:02:00Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 13150

shwstppr · 2025-04-23T13:51:27Z

@blueorangutan package

blueorangutan · 2025-04-23T13:52:04Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-04-23T15:13:57Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13153

github-actions · 2025-04-24T03:49:08Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

…ements Signed-off-by: Abhishek Kumar <[email protected]>

kiranchavala · 2025-04-24T13:17:45Z

@blueorangutan test

blueorangutan · 2025-04-24T13:20:04Z

@kiranchavala a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-04-24T13:24:09Z

[SF] Trillian Build Failed (tid-13132)

rohityadavcloud · 2025-04-25T02:04:30Z

@blueorangutan test

blueorangutan · 2025-04-25T02:06:03Z

@rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

kiranchavala

LGTM,

Test Case	Result
Check the label on the following sections (cluster, host, template, iso, iso, cks-iso, vm-instance, systemvm's	Pass
Test the configuration setting system.vm.preferred.architecture" at global and zone level"	Pass
UI: Test the vm deployment form for arch aware template and iso	Pass
UI : Test the filter dropdown on Cluster, Host, template, ISO, CKS-iso, vm's, systemvm's	Pass
Automatic download of systemvtemplate for aarch64 cluster should get triggered	Pass
Test the advanced zone deployment wizard for cluster type	Pass
Test the basic zone deployment wizard for cluster type	Pass
Test the Edge zone deployment wizard for cluster type	Pass
Updating of Cluster architecture should not be allowed if there are active host of different arch type	Pass

Some screenshots

blueorangutan · 2025-04-25T18:06:56Z

[SF] Trillian test result (tid-13133)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 54835 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10289-t13133-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_restore_vm_strict_tags_failure	`Failure`	57.42	test_vm_strict_host_tags.py
test_02_scale_vm_strict_tags_failure	`Failure`	56.55	test_vm_strict_host_tags.py
test_06_deploy_vm_on_any_host_with_strict_tags_failure	`Failure`	3.68	test_vm_strict_host_tags.py

boring-cyborg bot added the component:UI label Jan 28, 2025

boring-cyborg bot added component:api component:management-server labels Jan 29, 2025

shwstppr changed the title ~~ui: multi arch improvements~~ api,ui: multi arch improvements Jan 29, 2025

boring-cyborg bot added the component:simulator label Jan 29, 2025

shwstppr added 12 commits February 21, 2025 13:57

wip

e7ff4ed

Signed-off-by: Abhishek Kumar <[email protected]>

ui: multi-arch improvements

67042ce

Signed-off-by: Abhishek Kumar <[email protected]>

api,ui: filter resources by arch

126dfa9

Signed-off-by: Abhishek Kumar <[email protected]>

ui: show arch tag in infocard

8f48da3

Signed-off-by: Abhishek Kumar <[email protected]>

ui: add arch display and filter for kubernetes iso

13f3f14

Signed-off-by: Abhishek Kumar <[email protected]>

simulator: allow adding hosts with arch

b017025

Signed-off-by: Abhishek Kumar <[email protected]>

api,ui: allow filtering vms by arch

ee59e61

Signed-off-by: Abhishek Kumar <[email protected]>

ui: make arch filter a list

13ced5e

Signed-off-by: Abhishek Kumar <[email protected]>

wip

16282dd

Signed-off-by: Abhishek Kumar <[email protected]>

wip

bed9666

Signed-off-by: Abhishek Kumar <[email protected]>

change for downloading templates if allowed

969660a

Signed-off-by: Abhishek Kumar <[email protected]>

move download method to httputils

f74355f

Signed-off-by: Abhishek Kumar <[email protected]>

shwstppr force-pushed the multiarchzones-improvements branch from ca5dd68 to f74355f Compare February 21, 2025 08:58

boring-cyborg bot added component:build component:storage labels Feb 21, 2025

shwstppr added 6 commits February 21, 2025 14:36

remove unnecssary

9073ec1

Signed-off-by: Abhishek Kumar <[email protected]>

fix build

48c9d29

Signed-off-by: Abhishek Kumar <[email protected]>

fix

bc5f734

Signed-off-by: Abhishek Kumar <[email protected]>

remove unnecessary change

60dc9d9

Signed-off-by: Abhishek Kumar <[email protected]>

fixes

0ac96d6

Signed-off-by: Abhishek Kumar <[email protected]>

wip: try system vm deployment with different arch templates

33bb563

Signed-off-by: Abhishek Kumar <[email protected]>

boring-cyborg bot added component:secondary-storage component:ssvm labels Mar 6, 2025

fix checkstyle

42598f7

Signed-off-by: Abhishek Kumar <[email protected]>

shwstppr added 5 commits April 23, 2025 14:51

fix for cluster arch change

daac0d9

Signed-off-by: Abhishek Kumar <[email protected]>

fix lint

8ce28e7

Signed-off-by: Abhishek Kumar <[email protected]>

allow specifying arch for edge cluster

69db12a

Signed-off-by: Abhishek Kumar <[email protected]>

fix DISTINCT class field

a15aeb3

Signed-off-by: Abhishek Kumar <[email protected]>

tests

3807f17

Signed-off-by: Abhishek Kumar <[email protected]>

apache deleted a comment from blueorangutan Apr 23, 2025

github-actions bot added the status:has-conflicts label Apr 24, 2025

Merge remote-tracking branch 'apache/4.20' into multiarchzones-improv…

d8da081

…ements Signed-off-by: Abhishek Kumar <[email protected]>

github-actions bot removed the status:has-conflicts label Apr 24, 2025

rohityadavcloud marked this pull request as ready for review April 25, 2025 02:04

rohityadavcloud closed this Apr 25, 2025

github-project-automation bot moved this from In Progress to Done in ACS 4.20.1 Apr 25, 2025

rohityadavcloud reopened this Apr 25, 2025

kiranchavala approved these changes Apr 25, 2025

View reviewed changes

DaanHoogland merged commit 12c077d into apache:4.20 Apr 25, 2025
35 of 49 checks passed

DaanHoogland deleted the multiarchzones-improvements branch April 25, 2025 09:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

api,ui: multi arch improvements #10289

api,ui: multi arch improvements #10289

shwstppr commented Jan 28, 2025 •

edited

Loading

codecov bot commented Jan 28, 2025 •

edited

Loading

blueorangutan commented Apr 12, 2025

shwstppr commented Apr 23, 2025

blueorangutan commented Apr 23, 2025

blueorangutan commented Apr 23, 2025

shwstppr commented Apr 23, 2025

blueorangutan commented Apr 23, 2025

blueorangutan commented Apr 23, 2025

github-actions bot commented Apr 24, 2025

kiranchavala commented Apr 24, 2025

blueorangutan commented Apr 24, 2025

blueorangutan commented Apr 24, 2025

rohityadavcloud commented Apr 25, 2025

blueorangutan commented Apr 25, 2025

kiranchavala left a comment

blueorangutan commented Apr 25, 2025

api,ui: multi arch improvements #10289

api,ui: multi arch improvements #10289

Conversation

shwstppr commented Jan 28, 2025 • edited Loading

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov bot commented Jan 28, 2025 • edited Loading

Codecov Report

blueorangutan commented Apr 12, 2025

shwstppr commented Apr 23, 2025

blueorangutan commented Apr 23, 2025

blueorangutan commented Apr 23, 2025

shwstppr commented Apr 23, 2025

blueorangutan commented Apr 23, 2025

blueorangutan commented Apr 23, 2025

github-actions bot commented Apr 24, 2025

kiranchavala commented Apr 24, 2025

blueorangutan commented Apr 24, 2025

blueorangutan commented Apr 24, 2025

rohityadavcloud commented Apr 25, 2025

blueorangutan commented Apr 25, 2025

kiranchavala left a comment

Choose a reason for hiding this comment

blueorangutan commented Apr 25, 2025

shwstppr commented Jan 28, 2025 •

edited

Loading

codecov bot commented Jan 28, 2025 •

edited

Loading