Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix volume allocation logs #10475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix volume allocation logs #10475

wants to merge 2 commits into from

Conversation

julien-vaz
Copy link
Contributor

Description

The logs in storage allocation algorithms were displaying incorrect information about the allocation pool. Therefore, the logs were rewritten.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

How Has This Been Tested?

When trying to migrate a volume, the expected log messages were displayed correctly.

Improves StoragePoolAllocators' logs
a3ba22d 
Applies sugested changes
@codecov Codecov
Copy link

codecov bot commented Feb 28, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 16.15%. Comparing base (24b7c66) to head (34ad14b).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
...ge/allocator/ClusterScopeStoragePoolAllocator.java 0.00% 1 Missing ⚠️
...torage/allocator/ZoneWideStoragePoolAllocator.java 0.00% 1 Missing ⚠️
.../storage/allocator/RandomStoragePoolAllocator.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##              main   #10475       +/-   ##
============================================
+ Coverage     4.00%   16.15%   +12.15%     
- Complexity       0    13274    +13274     
============================================
  Files          396     5666     +5270     
  Lines        32530   498078   +465548     
  Branches      5766    60267    +54501     
============================================
+ Hits          1302    80480    +79178     
- Misses       31078   408584   +377506     
- Partials       150     9014     +8864
Flag Coverage Δ
uitests 4.00% <ø> (-0.01%) ⬇️
unittests 17.00% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@julien-vaz
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@julien-vaz a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12667

bernardodemarco
bernardodemarco approved these changes Apr 7, 2025
View reviewed changes
Copy link
Collaborator

@bernardodemarco bernardodemarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
Copy link
Contributor

@blueorangutan test

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-12903)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 126964 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10475-t12903-kvm-ol8.zip
Smoke tests completed. 114 look OK, 27 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_browser_migrate_template Error 65.77 test_image_store_object_migration.py
test_01_add_delete_kubernetes_supported_version Error 1801.93 test_kubernetes_supported_versions.py
ContextSuite context=TestListIdsParams>:setup Error 0.00 test_list_ids_parameter.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup Error 1519.62 test_network.py
ContextSuite context=TestPrivateGwACL>:setup Error 0.00 test_privategw_acl.py
ContextSuite context=TestIsolatedNetworksPasswdServer>:setup Error 0.00 test_password_server.py
ContextSuite context=TestPortForwardingRules>:setup Error 0.00 test_portforwardingrules.py
ContextSuite context=TestProjectSuspendActivate>:setup Error 1529.28 test_projects.py
test_06_purge_expunged_vm_background_task Failure 408.56 test_purge_expunged_vms.py
test_CRUD_operations_userdata Error 1522.30 test_register_userdata.py
test_deploy_vm_with_registered_userdata Error 7.89 test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_allow Error 7.29 test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_append Error 7.11 test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_deny Error 7.86 test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_params Error 7.35 test_register_userdata.py
test_link_and_unlink_userdata_to_template Error 7.49 test_register_userdata.py
test_user_userdata_crud Error 7.66 test_register_userdata.py
ContextSuite context=TestResetVmOnReboot>:setup Error 0.00 test_reset_vm_on_reboot.py
test_06_download_detached_volume Error 305.49 test_volumes.py
test_13_migrate_volume_and_change_offering Error 126.49 test_volumes.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup Error 0.00 test_resource_accounting.py
ContextSuite context=TestRestoreVM>:setup Error 0.00 test_restore_vm.py
ContextSuite context=TestRouterDHCPHosts>:setup Error 0.00 test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup Error 0.00 test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setup Error 0.00 test_router_dns.py
test_04_nonsecured_to_secured_vm_migration Error 150.57 test_vm_life_cycle.py
ContextSuite context=TestVMLifeCycle>:setup Error 7.01 test_vm_life_cycle.py
ContextSuite context=TestVPCRedundancy>:setup Error 0.00 test_vpc_redundant.py
ContextSuite context=TestVMSchedule>:setup Error 0.00 test_vm_schedule.py
ContextSuite context=TestVmSnapshot>:setup Error 7.34 test_vm_snapshots.py
ContextSuite context=TestMigrateVMStrictTags>:setup Error 0.00 test_vm_strict_host_tags.py
ContextSuite context=TestRestoreVMStrictTags>:setup Error 0.00 test_vm_strict_host_tags.py
ContextSuite context=TestScaleVMStrictTags>:setup Error 0.00 test_vm_strict_host_tags.py
ContextSuite context=TestVMDeploymentPlannerStrictTags>:setup Error 0.00 test_vm_strict_host_tags.py
test_04_deploy_vnf_appliance Error 312.02 test_vnf_templates.py
ContextSuite context=TestIpv6Vpc>:setup Error 0.00 test_vpc_ipv6.py
ContextSuite context=TestVPCNics>:setup Error 0.00 test_vpc_router_nics.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup Error 0.00 test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup Error 0.00 test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup Error 0.00 test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup Error 0.00 test_vpc_vpn.py
test_02_cancel_host_maintenace_with_migration_jobs Error 1.63 test_host_maintenance.py
test_03_cancel_host_maintenace_with_migration_jobs_failure Error 1.74 test_host_maintenance.py
test_01_cancel_host_maintenance_ssh_enabled_agent_connected Failure 18.65 test_host_maintenance.py
test_03_cancel_host_maintenance_ssh_disabled_agent_connected Failure 21.73 test_host_maintenance.py
test_04_cancel_host_maintenance_ssh_disabled_agent_disconnected Failure 29.32 test_host_maintenance.py
ContextSuite context=TestHostMaintenanceAgents>:teardown Error 30.51 test_host_maintenance.py
test_disable_oobm_ha_state_ineligible Error 1517.87 test_hostha_kvm.py

lucas-a-martins
lucas-a-martins approved these changes Apr 15, 2025
View reviewed changes
Copy link
Collaborator

@lucas-a-martins lucas-a-martins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@lucas-a-martins lucas-a-martins lucas-a-martins approved these changes

@bernardodemarco bernardodemarco bernardodemarco approved these changes

Assignees
No one assigned
Labels
component:storage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@julien-vaz @blueorangutan @DaanHoogland @lucas-a-martins @bernardodemarco