Instance lease: Allow deployment of instances with lease duration and leaseexpiry action #10560

sudo87 · 2025-03-13T03:06:01Z

Description

This PR enables Administrator to provide capability for end user to provision Lease based instances, which will be self destroyed or stopped once lease expires. This will improve efficient utilization of cloud infrastructure and reduce unused VMs in the cloud infrastructure.

Doc PR: apache/cloudstack-documentation#492

Feature can be enabled by updating value for following key to true:
instance.lease.enabled: true
default: false

There are additional configuration keys:

instance.lease.scheduler.interval: when scheduler will run to execute expiryaction, default value: 3600 (seconds)
instance.lease.alertscheduler.interval: alert scheduler interval, sends alerts for any instance which are about to expire in next 7 days (default: 86400)

Feature introduces new parameters in following APIs:
leaseduration: duration in days for which instance is provisioned
leaseexpiryaction: action will be executed once expiry is over

DeployVMCmd

deploy virtualmachine name=test-vm templateid=e6962fb7-fa6f-11ef-86b8-50eb71576f75 serviceofferingid=8fcc7ba4-298c-4c21-b5f6-c3c4e1d2afe7 leaseduration=10 leaseexpiryaction=STOP zoneid=988db21e-ffc9-4708-9546-797cb7592cb9

CreateServiceOfferingCmd

create serviceoffering name=cmd-lease leaseduration=10 leaseexpiryaction=STOP

UpdateVMCmd

update virtualmachine id=e22a2b2b-66c0-4566-9648-ec3219dbcb96 leaseduration=-1

Valid values for
leaseduration: positive number, negative value to removing lease from instance (-1)
leaseexpiryaction: STOP | DESTROY

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

…syncjobmanager

config key setup and configured for alert email lease options in create and update vm screen handle delete protection, edit vm, create vm validated stop and detroy, delete protection

…e offering

…us UI elements

…rsona, bug fixes

sudo87 · 2025-03-13T03:29:50Z

@blueorangutan package

blueorangutan · 2025-03-13T03:32:03Z

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-03-13T03:54:50Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 12761

...src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java

codecov · 2025-03-13T05:57:48Z

Codecov Report

Attention: Patch coverage is 42.19780% with 263 lines in your changes missing coverage. Please review.

Project coverage is 16.43%. Comparing base (39c5641) to head (41dd137).

Files with missing lines	Patch %	Lines
...apache/cloudstack/vm/lease/VMLeaseManagerImpl.java	43.54%	95 Missing and 10 partials ⚠️
...ava/com/cloud/api/query/dao/UserVmJoinDaoImpl.java	38.00%	28 Missing and 3 partials ⚠️
.../cloud/configuration/ConfigurationManagerImpl.java	10.71%	25 Missing ⚠️
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java	75.90%	10 Missing and 10 partials ⚠️
...apache/cloudstack/api/response/UserVmResponse.java	0.00%	18 Missing ⚠️
...main/java/com/cloud/api/query/vo/UserVmJoinVO.java	0.00%	13 Missing ⚠️
...oudstack/api/response/ServiceOfferingResponse.java	0.00%	12 Missing ⚠️
...ain/java/com/cloud/api/query/QueryManagerImpl.java	0.00%	8 Missing ⚠️
...he/cloudstack/api/command/user/vm/DeployVMCmd.java	0.00%	6 Missing ⚠️
...he/cloudstack/api/command/user/vm/UpdateVMCmd.java	0.00%	6 Missing ⚠️
... and 6 more

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #10560      +/-   ##
============================================
+ Coverage     16.40%   16.43%   +0.02%     
- Complexity    13590    13621      +31     
============================================
  Files          5692     5694       +2     
  Lines        501976   502502     +526     
  Branches      60795    60878      +83     
============================================
+ Hits          82369    82575     +206     
- Misses       410449   410747     +298     
- Partials       9158     9180      +22

Flag	Coverage Δ
uitests	`3.99% <ø> (-0.01%)`	⬇️
unittests	`17.29% <42.19%> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

shwstppr

@sudo87 build failing with unit tests failure. Please check

server/src/test/java/org/apache/cloudstack/vm/lease/VMLeaseManagerImplTest.java

sudo87 · 2025-03-17T05:14:20Z

@blueorangutan package

blueorangutan · 2025-03-17T05:16:03Z

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-03-17T05:56:29Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 12802

…n tests

sureshanaparti

code lgtm

sudo87 · 2025-04-24T15:08:33Z

@blueorangutan package

blueorangutan · 2025-04-24T15:10:06Z

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-04-24T16:42:40Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13169

sudo87 · 2025-04-25T03:48:26Z

@blueorangutan test matrix

blueorangutan · 2025-04-25T03:50:04Z

@sudo87 a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests

blueorangutan · 2025-04-25T21:04:23Z

[SF] Trillian test result (tid-13135)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 59003 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10560-t13135-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_restore_vm_strict_tags_failure	`Failure`	56.60	test_vm_strict_host_tags.py
test_02_scale_vm_strict_tags_failure	`Failure`	60.92	test_vm_strict_host_tags.py
test_06_deploy_vm_on_any_host_with_strict_tags_failure	`Failure`	6.02	test_vm_strict_host_tags.py

blueorangutan · 2025-04-26T01:20:14Z

[SF] Trillian test result (tid-13137)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 74713 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10560-t13137-vmware-70u3.zip
Smoke tests completed. 133 look OK, 8 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_events_resource	`Error`	402.70	test_events_resource.py
test_deploy_more_vms_than_limit_allows	`Error`	180.72	test_deploy_vms_in_parallel.py
test_02_enableHumanReadableLogs	`Error`	0.44	test_human_readable_logs.py
test_01_prepare_and_cancel_maintenance	`Error`	0.16	test_ms_maintenance_and_safe_shutdown.py
test_04_deploy_vm_for_other_user_and_test_vm_operations	`Error`	130.75	test_network_permissions.py
test_02_verifyRouterIpAfterNetworkRestart	`Failure`	142.20	test_network.py
test_01_deployVMInSharedNetwork	`Failure`	3609.35	test_network.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:teardown	`Error`	3610.60	test_network.py
test_02_restore_vm_with_disk_offering	`Error`	70.79	test_restore_vm.py
test_03_restore_vm_with_disk_offering_custom_size	`Error`	60.47	test_restore_vm.py
test_02_restore_vm_strict_tags_failure	`Failure`	65.22	test_vm_strict_host_tags.py
test_02_restore_vm_strict_tags_failure	`Error`	65.22	test_vm_strict_host_tags.py
test_02_scale_vm_strict_tags_failure	`Failure`	58.91	test_vm_strict_host_tags.py
test_06_deploy_vm_on_any_host_with_strict_tags_failure	`Failure`	3.81	test_vm_strict_host_tags.py

blueorangutan · 2025-04-26T04:19:13Z

[SF] Trillian test result (tid-13138)
Environment: xcpng82 (x2), Advanced Networking with Mgmt server ol9
Total time taken: 85933 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10560-t13138-xcpng82.zip
Smoke tests completed. 133 look OK, 8 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_condensed_drs_algorithm	`Failure`	168.52	test_cluster_drs.py
test_02_balanced_drs_algorithm	`Failure`	183.63	test_cluster_drs.py
test_01_prepare_and_cancel_maintenance	`Error`	0.12	test_ms_maintenance_and_safe_shutdown.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup	`Error`	10.62	test_network.py
test_01_non_strict_host_anti_affinity	`Error`	247.91	test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity	`Error`	117.84	test_nonstrict_affinity_group.py
test_02_create_volume	`Error`	5.36	test_resource_names.py
test_05_scale_vm_dont_allow_disk_offering_change	`Failure`	83.36	test_scale_vm.py
test_01_volume_usage	`Error`	101.68	test_usage.py
test_02_restore_vm_strict_tags_failure	`Failure`	68.79	test_vm_strict_host_tags.py
test_02_scale_vm_strict_tags_failure	`Failure`	94.61	test_vm_strict_host_tags.py
test_06_deploy_vm_on_any_host_with_strict_tags_failure	`Failure`	5.80	test_vm_strict_host_tags.py

blueorangutan · 2025-04-26T08:11:49Z

[SF] Trillian test result (tid-13136)
Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22
Total time taken: 99769 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10560-t13136-kvm-ubuntu22.zip
Smoke tests completed. 100 look OK, 41 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_nic_secondaryip_add_remove	`Error`	23.72	test_multipleips_per_nic.py
test_network_acl	`Error`	2.39	test_network_acl.py
test_01_verify_ipv6_network	`Error`	4.00	test_network_ipv6.py
test_01_verify_ipv6_network	`Error`	4.00	test_network_ipv6.py
test_03_network_operations_on_created_vm_of_otheruser	`Error`	2.74	test_network_permissions.py
test_03_network_operations_on_created_vm_of_otheruser	`Error`	2.74	test_network_permissions.py
test_04_deploy_vm_for_other_user_and_test_vm_operations	`Failure`	1.57	test_network_permissions.py
ContextSuite context=TestNetworkPermissions>:teardown	`Error`	1.60	test_network_permissions.py
test_delete_account	`Error`	22.05	test_network.py
test_delete_network_while_vm_on_it	`Error`	2.54	test_network.py
test_delete_network_while_vm_on_it	`Error`	2.54	test_network.py
test_deploy_vm_l2network	`Error`	2.44	test_network.py
test_deploy_vm_l2network	`Error`	2.45	test_network.py
test_l2network_restart	`Error`	3.62	test_network.py
test_l2network_restart	`Error`	3.62	test_network.py
ContextSuite context=TestL2Networks>:teardown	`Error`	4.76	test_network.py
ContextSuite context=TestPortForwarding>:setup	`Error`	11.71	test_network.py
ContextSuite context=TestPublicIP>:setup	`Error`	12.34	test_network.py
test_reboot_router	`Error`	6.91	test_network.py
test_releaseIP	`Error`	7.41	test_network.py
test_releaseIP_using_IP	`Error`	6.40	test_network.py
ContextSuite context=TestRouterRules>:setup	`Error`	12.77	test_network.py
test_01_deployVMInSharedNetwork	`Failure`	1.28	test_network.py
test_02_verifyRouterIpAfterNetworkRestart	`Failure`	2.10	test_network.py
test_03_destroySharedNetwork	`Failure`	1.10	test_network.py
ContextSuite context=TestSharedNetwork>:teardown	`Error`	2.19	test_network.py
test_01_deployVMInSharedNetwork	`Failure`	1.38	test_network.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:teardown	`Error`	2.49	test_network.py
test_01_nic	`Error`	55.24	test_nic.py
test_01_non_strict_host_anti_affinity	`Error`	3.15	test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity	`Error`	3.63	test_nonstrict_affinity_group.py
test_oobm_multiple_mgmt_server_ownership	`Failure`	31.87	test_outofbandmanagement.py
ContextSuite context=TestIsolatedNetworksPasswdServer>:setup	`Error`	0.00	test_password_server.py
test_01_isolated_persistent_network	`Error`	0.41	test_persistent_network.py
test_02_L2_persistent_network	`Error`	1.34	test_persistent_network.py
test_03_deploy_and_destroy_VM_and_verify_network_resources_persist	`Failure`	2.67	test_persistent_network.py
test_03_deploy_and_destroy_VM_and_verify_network_resources_persist	`Error`	2.67	test_persistent_network.py
ContextSuite context=TestL2PersistentNetworks>:teardown	`Error`	2.78	test_persistent_network.py
test_01_create_delete_portforwarding_fornonvpc	`Error`	7.73	test_portforwardingrules.py
test_01_add_primary_storage_disabled_host	`Error`	0.33	test_primary_storage.py
test_01_primary_storage_nfs	`Error`	0.26	test_primary_storage.py
ContextSuite context=TestStorageTags>:setup	`Error`	0.44	test_primary_storage.py
test_01_primary_storage_scope_change	`Error`	0.12	test_primary_storage_scope.py
test_01_vpc_privategw_acl	`Failure`	8.12	test_privategw_acl.py
test_02_vpc_privategw_static_routes	`Failure`	8.22	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	`Failure`	8.41	test_privategw_acl.py
test_04_rvpc_privategw_static_routes	`Failure`	8.65	test_privategw_acl.py
test_09_project_suspend	`Error`	2.74	test_projects.py
test_10_project_activation	`Error`	2.69	test_projects.py
test_01_purge_expunged_api_vm_start_date	`Error`	3.14	test_purge_expunged_vms.py
test_02_purge_expunged_api_vm_end_date	`Error`	3.01	test_purge_expunged_vms.py
test_03_purge_expunged_api_vm_start_end_date	`Error`	2.84	test_purge_expunged_vms.py
test_04_purge_expunged_api_vm_no_date	`Error`	2.02	test_purge_expunged_vms.py
test_05_purge_expunged_vm_service_offering	`Error`	1.58	test_purge_expunged_vms.py
test_06_purge_expunged_vm_background_task	`Error`	360.54	test_purge_expunged_vms.py
test_CRUD_operations_userdata	`Error`	1523.19	test_register_userdata.py
test_deploy_vm_with_registered_userdata	`Error`	7.65	test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_allow	`Error`	8.47	test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_append	`Error`	8.46	test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_deny	`Error`	7.63	test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_params	`Error`	7.96	test_register_userdata.py
test_link_and_unlink_userdata_to_template	`Error`	8.90	test_register_userdata.py
test_user_userdata_crud	`Error`	7.99	test_register_userdata.py
ContextSuite context=TestResetVmOnReboot>:setup	`Error`	0.00	test_reset_vm_on_reboot.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup	`Error`	0.00	test_resource_accounting.py
ContextSuite context=TestResourceNames>:setup	`Error`	0.00	test_resource_names.py
ContextSuite context=TestRestoreVM>:setup	`Error`	0.00	test_restore_vm.py
ContextSuite context=TestRouterDHCPHosts>:setup	`Error`	0.00	test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup	`Error`	0.00	test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setup	`Error`	0.00	test_router_dns.py
ContextSuite context=TestRouterDnsService>:setup	`Error`	0.00	test_router_dnsservice.py
ContextSuite context=TestRouterIpTablesPolicies>:setup	`Error`	0.00	test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup	`Error`	0.00	test_routers_iptables_default_policy.py
test_01_migrate_vm_strict_tags_success	`Error`	0.32	test_vm_strict_host_tags.py
test_02_migrate_vm_strict_tags_failure	`Error`	0.30	test_vm_strict_host_tags.py
test_01_restore_vm_strict_tags_success	`Error`	0.28	test_vm_strict_host_tags.py
test_02_restore_vm_strict_tags_failure	`Error`	0.28	test_vm_strict_host_tags.py
test_01_scale_vm_strict_tags_success	`Error`	0.28	test_vm_strict_host_tags.py
test_02_scale_vm_strict_tags_failure	`Error`	0.34	test_vm_strict_host_tags.py
test_01_deploy_vm_on_specific_host_without_strict_tags	`Error`	0.43	test_vm_strict_host_tags.py
test_02_deploy_vm_on_any_host_without_strict_tags	`Error`	6.18	test_vm_strict_host_tags.py
test_03_deploy_vm_on_specific_host_with_strict_tags_success	`Error`	0.37	test_vm_strict_host_tags.py
test_04_deploy_vm_on_any_host_with_strict_tags_success	`Error`	4.01	test_vm_strict_host_tags.py
test_05_deploy_vm_on_specific_host_with_strict_tags_failure	`Failure`	0.38	test_vm_strict_host_tags.py
test_06_deploy_vm_on_any_host_with_strict_tags_failure	`Failure`	3.93	test_vm_strict_host_tags.py
ContextSuite context=TestIsolatedNetworks>:setup	`Error`	0.00	test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup	`Error`	0.00	test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setup	`Error`	0.00	test_routers.py
test_01_sys_vm_start	`Failure`	0.13	test_secondary_storage.py
ContextSuite context=TestCpuCapServiceOfferings>:setup	`Error`	0.00	test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup	`Error`	0.35	test_service_offerings.py
ContextSuite context=TestSetSourceNatIp>:setup	`Error`	0.00	test_set_sourcenat.py
ContextSuite context=TestSharedFSLifecycle>:setup	`Error`	0.00	test_sharedfs_lifecycle.py
ContextSuite context=TestSnapshotRootDisk>:setup	`Error`	0.00	test_snapshots.py
ContextSuite context=TestSnapshotStandaloneBackup>:setup	`Error`	0.00	test_snapshots.py
test_01_list_sec_storage_vm	`Failure`	0.04	test_ssvm.py
test_02_list_cpvm_vm	`Failure`	0.04	test_ssvm.py
test_03_ssvm_internals	`Failure`	0.04	test_ssvm.py
test_04_cpvm_internals	`Failure`	0.04	test_ssvm.py
test_05_stop_ssvm	`Failure`	0.04	test_ssvm.py
test_06_stop_cpvm	`Failure`	0.04	test_ssvm.py
test_07_reboot_ssvm	`Failure`	0.05	test_ssvm.py
test_08_reboot_cpvm	`Failure`	0.05	test_ssvm.py
test_09_reboot_ssvm_forced	`Failure`	0.04	test_ssvm.py
test_10_reboot_cpvm_forced	`Failure`	0.05	test_ssvm.py
test_11_destroy_ssvm	`Failure`	0.05	test_ssvm.py
test_12_destroy_cpvm	`Failure`	0.05	test_ssvm.py
ContextSuite context=TestVMWareStoragePolicies>:setup	`Error`	0.00	test_storage_policy.py
test_02_create_template_with_checksum_sha1	`Error`	65.66	test_templates.py
test_03_create_template_with_checksum_sha256	`Error`	65.70	test_templates.py
test_04_create_template_with_checksum_md5	`Error`	65.69	test_templates.py
test_05_create_template_with_no_checksum	`Error`	65.67	test_templates.py
test_01_register_template_direct_download_flag	`Error`	0.06	test_templates.py
test_02_deploy_vm_from_direct_download_template	`Error`	0.00	test_templates.py
test_03_deploy_vm_wrong_checksum	`Error`	0.06	test_templates.py
ContextSuite context=TestTemplates>:setup	`Error`	14.04	test_templates.py
test_01_redundant_vpc_site2site_vpn	`Failure`	568.85	test_vpc_vpn.py
ContextSuite context=TestISOUsage>:setup	`Error`	0.00	test_usage.py
ContextSuite context=TestLBRuleUsage>:setup	`Error`	0.00	test_usage.py
ContextSuite context=TestNatRuleUsage>:setup	`Error`	0.00	test_usage.py
ContextSuite context=TestPublicIPUsage>:setup	`Error`	0.00	test_usage.py
ContextSuite context=TestSnapshotUsage>:setup	`Error`	0.00	test_usage.py
ContextSuite context=TestVmUsage>:setup	`Error`	0.00	test_usage.py
ContextSuite context=TestVolumeUsage>:setup	`Error`	0.00	test_usage.py
ContextSuite context=TestVpnUsage>:setup	`Error`	0.00	test_usage.py
test_01_scale_up_verify	`Failure`	35.06	test_vm_autoscaling.py
test_02_update_vmprofile_and_vmgroup	`Failure`	245.70	test_vm_autoscaling.py
test_03_scale_down_verify	`Failure`	304.63	test_vm_autoscaling.py
test_04_stop_remove_vm_in_vmgroup	`Failure`	0.03	test_vm_autoscaling.py
test_06_autoscaling_vmgroup_on_project_network	`Failure`	41.68	test_vm_autoscaling.py
test_06_autoscaling_vmgroup_on_project_network	`Error`	41.69	test_vm_autoscaling.py
test_07_autoscaling_vmgroup_on_vpc_network	`Error`	1.23	test_vm_autoscaling.py
ContextSuite context=TestVmAutoScaling>:teardown	`Error`	12.42	test_vm_autoscaling.py
test_01_deploy_vm_on_specific_host	`Error`	0.10	test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster	`Error`	1.39	test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod	`Error`	1.40	test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster	`Error`	0.14	test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod	`Error`	1.34	test_vm_deployment_planner.py
test_01_migrate_VM_and_root_volume	`Error`	124.69	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	`Error`	54.21	test_vm_life_cycle.py
test_01_secure_vm_migration	`Error`	77.55	test_vm_life_cycle.py
test_02_unsecure_vm_migration	`Error`	244.97	test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration	`Error`	156.13	test_vm_life_cycle.py
test_08_migrate_vm	`Error`	0.08	test_vm_life_cycle.py

github-actions · 2025-04-28T08:49:47Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

github-actions · 2025-05-02T10:35:24Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

sudo87 · 2025-05-05T10:31:41Z

@blueorangutan package

blueorangutan · 2025-05-05T10:34:04Z

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-05-05T11:52:25Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13260

sudo87 · 2025-05-05T12:42:12Z

@blueorangutan test

blueorangutan · 2025-05-05T12:44:03Z

@sudo87 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-05-06T05:11:28Z

[SF] Trillian test result (tid-13203)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 56548 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10560-t13203-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

sudo87 · 2025-05-07T07:30:52Z

@blueorangutan package

blueorangutan · 2025-05-07T07:32:03Z

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-05-07T08:38:41Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13285

sudo87 added 12 commits February 21, 2025 13:54

FR-248: Instance lease, WIP commit

d737cea

insert lease expiry into db and use that to filter exiring vms, add a…

9bef279

…syncjobmanager

Add leaseDuration and leaseExpiryAction in Service offering create flow

759f1fa

Update listVM cmd to allow listing only leased instances

8c7a9f2

Add methods to fetch instances for which lease is expiring in next days

1495b08

Changes included:

e2da246

config key setup and configured for alert email lease options in create and update vm screen handle delete protection, edit vm, create vm validated stop and detroy, delete protection

Update UI screens for leased properties coming from config and servic…

0969bf0

…e offering

use global lock before running scheduler

f239e92

Unit tests

e7ce8ae

Flow changes done in UI based on discussion

0cf2fe8

Include view changes in schema upgrade files and use feature in vario…

7bc5f2a

…us UI elements

Added integration test for vm deployment, UI enhancements for user pe…

aff544f

…rsona, bug fixes

boring-cyborg bot added component:api component:integration-test component:management-server Python Warning... Python code Ahead! labels Mar 13, 2025

validate integration tests, minor ui changes and log messages

62397cc

sudo87 force-pushed the int_fr_248 branch from 59ee208 to 62397cc Compare March 13, 2025 03:13

vishesh92 reviewed Mar 13, 2025

View reviewed changes

...src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java Outdated Show resolved Hide resolved

shwstppr reviewed Mar 13, 2025

View reviewed changes

server/src/test/java/org/apache/cloudstack/vm/lease/VMLeaseManagerImplTest.java Outdated Show resolved Hide resolved

fix build: moving configkey from setup to test itself

faf484f

Disable testAlert to unblock build and trim whitespaces in integratio…

410a882

…n tests

sudo87 force-pushed the int_fr_248 branch from 338edd7 to 410a882 Compare March 17, 2025 07:12

sureshanaparti approved these changes Apr 24, 2025

View reviewed changes

github-actions bot added the status:has-conflicts label Apr 28, 2025

resolve merge conflict with main

764900b

github-actions bot added status:has-conflicts and removed status:has-conflicts labels Apr 28, 2025

sudo87 added 2 commits May 5, 2025 13:19

bug fix in edit instance flow and reject api request for invalid values

5b09778

resolve merge conflict with main

3bc3a53

github-actions bot removed the status:has-conflicts label May 5, 2025

sudo87 added 2 commits May 6, 2025 11:53

max allowed lease is for 100 years

a04718f

log instance ids for expired instance

41dd137

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Instance lease: Allow deployment of instances with lease duration and leaseexpiry action #10560

Instance lease: Allow deployment of instances with lease duration and leaseexpiry action #10560

sudo87 commented Mar 13, 2025 •

edited by sureshanaparti

Loading

sudo87 commented Mar 13, 2025

blueorangutan commented Mar 13, 2025

blueorangutan commented Mar 13, 2025

codecov bot commented Mar 13, 2025 •

edited

Loading

shwstppr left a comment

sudo87 commented Mar 17, 2025

blueorangutan commented Mar 17, 2025

blueorangutan commented Mar 17, 2025

sureshanaparti left a comment

sudo87 commented Apr 24, 2025

blueorangutan commented Apr 24, 2025

blueorangutan commented Apr 24, 2025

sudo87 commented Apr 25, 2025

blueorangutan commented Apr 25, 2025

blueorangutan commented Apr 25, 2025

blueorangutan commented Apr 26, 2025

blueorangutan commented Apr 26, 2025

blueorangutan commented Apr 26, 2025

github-actions bot commented Apr 28, 2025

github-actions bot commented May 2, 2025

sudo87 commented May 5, 2025

blueorangutan commented May 5, 2025

blueorangutan commented May 5, 2025

sudo87 commented May 5, 2025

blueorangutan commented May 5, 2025

blueorangutan commented May 6, 2025

sudo87 commented May 7, 2025

blueorangutan commented May 7, 2025

blueorangutan commented May 7, 2025

Instance lease: Allow deployment of instances with lease duration and leaseexpiry action #10560

Are you sure you want to change the base?

Instance lease: Allow deployment of instances with lease duration and leaseexpiry action #10560

Conversation

sudo87 commented Mar 13, 2025 • edited by sureshanaparti Loading

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

sudo87 commented Mar 13, 2025

blueorangutan commented Mar 13, 2025

blueorangutan commented Mar 13, 2025

codecov bot commented Mar 13, 2025 • edited Loading

Codecov Report

shwstppr left a comment

Choose a reason for hiding this comment

sudo87 commented Mar 17, 2025

blueorangutan commented Mar 17, 2025

blueorangutan commented Mar 17, 2025

sureshanaparti left a comment

Choose a reason for hiding this comment

sudo87 commented Apr 24, 2025

blueorangutan commented Apr 24, 2025

blueorangutan commented Apr 24, 2025

sudo87 commented Apr 25, 2025

blueorangutan commented Apr 25, 2025

blueorangutan commented Apr 25, 2025

blueorangutan commented Apr 26, 2025

blueorangutan commented Apr 26, 2025

blueorangutan commented Apr 26, 2025

github-actions bot commented Apr 28, 2025

github-actions bot commented May 2, 2025

sudo87 commented May 5, 2025

blueorangutan commented May 5, 2025

blueorangutan commented May 5, 2025

sudo87 commented May 5, 2025

blueorangutan commented May 5, 2025

blueorangutan commented May 6, 2025

sudo87 commented May 7, 2025

blueorangutan commented May 7, 2025

blueorangutan commented May 7, 2025

sudo87 commented Mar 13, 2025 •

edited by sureshanaparti

Loading

codecov bot commented Mar 13, 2025 •

edited

Loading