UI: Restore AS Numbers and IPv4 Subnets menus #10580
Conversation
4d2b0c2 to
84a2b04
Compare
|
@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #10580 +/- ##
=========================================
Coverage 16.00% 16.01%
- Complexity 13104 13115 +11
=========================================
Files 5651 5651
Lines 495843 495881 +38
Branches 60045 60048 +3
=========================================
+ Hits 79363 79410 +47
+ Misses 407624 407608 -16
- Partials 8856 8863 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
UI build: ✔️ |
|
I think we need to add some more changes back from the 34d2a3b. Specifically around guest network's details, bgp.peer, rotuing.firewall tab, etc. |
|
Thanks @vishesh92 I have addressed that on the last commit, can you please re-review? |
|
@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
@vishesh92 is your concern addressed? |
|
@nvazquez can you also revert this change |
|
@blueorangutan test keepEnv |
|
@rosi-shapeblue a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
Thanks @vishesh92 - I have addressed your last comments, can you please re-review? @blueorangutan package |
|
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12981 |
|
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
I am not sure why, this works in a 4.20.1 lab env but not against qa, something is incompatible between the new UI and the old API , I think. I also think this is good for merge. |
it might be better to have QAs for at least 3 ACS versions
|
|
Hi guys, I've done dev testing for 4.20 and main branches as both were affected and this PR fixed it. Will double check 4.19 |
|
@weizhouapache @DaanHoogland @Pearl1594 4.19 is not affected as the feature that introduced AS Numbers and IPv4 Subnets sections was introduced on 4.20 (#9470) |
|
thanks @nvazquez verified locally left panel tab of routed network details of routed network |
Description
This PR fixes a regression on the UI in which the AS Numbers menu tab was removed, caused by the merge commit: 34d2a3b (check network.js file diff)
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Before:
After:
How did you try to break this feature and the system with this change?