Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix issue with allocator not considering subsequent clusters #10603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 22, 2025
Merged

Fix issue with allocator not considering subsequent clusters #10603

merged 4 commits into from
Apr 22, 2025

Conversation

Pearl1594
Copy link
Contributor

Description

This PR fixes: #10598
While #8611 seems to have fixed this issue in 4.19.1, I believe it got lost in the process of resolving merge conflicts / forward merging into 4.20.0.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@Pearl1594 Pearl1594 linked an issue Mar 21, 2025 that may be closed by this pull request
FirstFitRouting Allocator only tries the first cluster it finds then fails before attempting others #10598
Closed
@Pearl1594 Pearl1594 moved this to In Progress in ACS 4.20.1 Mar 21, 2025
@codecov Codecov
Copy link

codecov bot commented Mar 21, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 16.01%. Comparing base (653b973) to head (0977c5c).
Report is 46 commits behind head on 4.20.

Files with missing lines Patch % Lines
.../agent/manager/allocator/impl/RandomAllocator.java 0.00% 6 Missing ⚠️
...gent/manager/allocator/impl/FirstFitAllocator.java 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##               4.20   #10603   +/-   ##
=========================================
  Coverage     16.00%   16.01%           
- Complexity    13104    13118   +14     
=========================================
  Files          5651     5651           
  Lines        495870   495895   +25     
  Branches      60049    60057    +8     
=========================================
+ Hits          79370    79422   +52     
+ Misses       407638   407617   -21     
+ Partials       8862     8856    -6
Flag Coverage Δ
uitests 4.00% <ø> (ø)
unittests 16.85% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@weizhouapache
Copy link
Member

oh, check-style error

Error:  /home/runner/work/cloudstack/cloudstack/server/src/main/java/com/cloud/agent/manager/allocator/impl/FirstFitAllocator.java:28:8: Unused import - com.cloud.utils.exception.CloudRuntimeException. [UnusedImports]

@weizhouapache
Copy link
Member

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12856

@weizhouapache
Copy link
Member

@blueorangutan test

@blueorangutan
Copy link

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-12800)

@weizhouapache
Copy link
Member

@blueorangutan test

@blueorangutan
Copy link

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-12801)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 58506 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10603-t12801-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_02_restore_vm_strict_tags_failure Failure 56.38 test_vm_strict_host_tags.py
test_02_scale_vm_strict_tags_failure Failure 64.69 test_vm_strict_host_tags.py
test_06_deploy_vm_on_any_host_with_strict_tags_failure Failure 5.64 test_vm_strict_host_tags.py

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

shwstppr
shwstppr approved these changes Mar 26, 2025
View reviewed changes
Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

weizhouapache
weizhouapache approved these changes Mar 26, 2025
View reviewed changes
Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

DaanHoogland
DaanHoogland approved these changes Mar 26, 2025
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@Pearl1594
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12905

@Pearl1594
Copy link
Contributor Author

@blueorangutan test

@blueorangutan
Copy link

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-12847)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 56306 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10603-t12847-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_02_restore_vm_strict_tags_failure Failure 53.37 test_vm_strict_host_tags.py
test_02_scale_vm_strict_tags_failure Failure 54.44 test_vm_strict_host_tags.py
test_06_deploy_vm_on_any_host_with_strict_tags_failure Failure 5.72 test_vm_strict_host_tags.py

@vishesh92 vishesh92 mentioned this pull request Apr 18, 2025
Closed
@Pearl1594 Pearl1594 merged commit 0da243d into 4.20 Apr 22, 2025
48 of 50 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in ACS 4.20.1 Apr 22, 2025
@vishesh92 vishesh92 deleted the fix-allocator-logic branch April 23, 2025 07:45
@Pearl1594 Pearl1594 mentioned this pull request May 2, 2025
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwstppr shwstppr shwstppr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

@JoaoJandre JoaoJandre Awaiting requested review from JoaoJandre

Assignees
No one assigned
Labels
None yet
Projects
ACS 4.20.1
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FirstFitRouting Allocator only tries the first cluster it finds then fails before attempting others
5 participants
@Pearl1594 @weizhouapache @blueorangutan @shwstppr @DaanHoogland