Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Support XenServer 8.4 / XCP 8.3 - make scripts python3 compatible #10684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 36 commits into
base: 4.20
Choose a base branch
from
Open

Support XenServer 8.4 / XCP 8.3 - make scripts python3 compatible #10684

wants to merge 36 commits into from

Conversation

Pearl1594
Copy link
Contributor

@Pearl1594 Pearl1594 commented Apr 9, 2025 •
edited
Loading

Description

This PR is just to test #10483

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

rohityadavcloud and others added 6 commits February 28, 2025 11:07
@rohityadavcloud
schema: add XS 8.3, 8.4 hypervisor capabilities
73e5576 
This aims to add support for XenServer 8.4 and XCP-ng 8.3.

Signed-off-by: Rohit Yadav <[email protected]>
@rohityadavcloud
fix os mappings
78da6ec 
Signed-off-by: Rohit Yadav <[email protected]>
@rohityadavcloud
fix more mappings
b73bc69 
Signed-off-by: Rohit Yadav <[email protected]>
@rohityadavcloud
fix os mappings order
31123e3 
Signed-off-by: Rohit Yadav <[email protected]>
@Pearl1594
Use Python3 for Xenserver 8.4
9a99c43
@Pearl1594
Merge branch '4.20' of https://github.com/apache/cloudstack into supp…
5e2afc3 
…ort-xen84-py3
@boring-cyborg boring-cyborg bot added component:XenServer Python Warning... Python code Ahead! labels Apr 9, 2025
@Pearl1594
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov Codecov
Copy link

codecov bot commented Apr 9, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 203 lines in your changes missing coverage. Please review.

Project coverage is 16.12%. Comparing base (c1923a2) to head (0c8a738).
Report is 3 commits behind head on 4.20.

Files with missing lines Patch % Lines
.../main/java/com/xensource/xenapi/ConnectionNew.java 0.00% 156 Missing ⚠️
...rce/wrapper/xenbase/CitrixStartCommandWrapper.java 0.00% 18 Missing ⚠️
...cloudstack/storage/template/UploadManagerImpl.java 0.00% 10 Missing ⚠️
...isor/xenserver/discoverer/XcpServerDiscoverer.java 0.00% 4 Missing ⚠️
...ervisor/xenserver/resource/CitrixResourceBase.java 0.00% 4 Missing ⚠️
...rvisor/xenserver/resource/XcpServer83Resource.java 0.00% 4 Missing ⚠️
...rvisor/xenserver/resource/Xenserver84Resource.java 0.00% 4 Missing ⚠️
...or/xenserver/resource/XenServerConnectionPool.java 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               4.20   #10684      +/-   ##
============================================
- Coverage     16.13%   16.12%   -0.01%     
- Complexity    13219    13220       +1     
============================================
  Files          5651     5654       +3     
  Lines        496740   496988     +248     
  Branches      60183    60238      +55     
============================================
+ Hits          80136    80154      +18     
- Misses       407680   407910     +230     
  Partials       8924     8924
Flag Coverage Δ
uitests 4.00% <ø> (-0.01%) ⬇️
unittests 16.97% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12999

@weizhouapache
Copy link
Member

@blueorangutan test ol8 xenserver-84 keepEnv

@blueorangutan
Copy link

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + xenserver-84) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-12931)

DaanHoogland
DaanHoogland reviewed Apr 10, 2025
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint issues

@rohityadavcloud rohityadavcloud mentioned this pull request Apr 10, 2025
Closed
14 tasks
@rohityadavcloud rohityadavcloud added this to the 4.20.1 milestone Apr 10, 2025
@rohityadavcloud
Copy link
Member

Good to see this, @Pearl1594 can we also add support for XCP-ng 8.3 (& related files as needed)? cc @weizhouapache @harikrishna-patnala

@Pearl1594
Copy link
Contributor Author

yes @rohityadavcloud . Working with @harikrishna-patnala towards that.

@Pearl1594
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@Pearl1594
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13263

@Pearl1594
Copy link
Contributor Author

@blueorangutan test matrix

@blueorangutan
Copy link

@Pearl1594 a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests

@Pearl1594
Copy link
Contributor Author

@blueorangutan test ol8 xenserver-84

@blueorangutan
Copy link

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + xenserver-84) has been kicked to run smoke tests

@Pearl1594
Copy link
Contributor Author

@blueorangutan test ol8 xcpng83

@blueorangutan
Copy link

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + xcpng83) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-13206)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 56594 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10684-t13206-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@blueorangutan
Copy link

[SF] Trillian test result (tid-13207)
Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22
Total time taken: 61798 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10684-t13207-kvm-ubuntu22.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_oobm_multiple_mgmt_server_ownership Failure 30.88 test_outofbandmanagement.py
test_02_list_cpvm_vm Failure 0.04 test_ssvm.py
test_04_cpvm_internals Failure 0.05 test_ssvm.py

@blueorangutan
Copy link

[SF] Trillian test result (tid-13208)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 67120 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10684-t13208-vmware-70u3.zip
Smoke tests completed. 138 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_deployVMInSharedNetwork Error 181.12 test_network.py
test_02_restore_vm_with_disk_offering Error 63.66 test_restore_vm.py
test_03_restore_vm_with_disk_offering_custom_size Error 59.47 test_restore_vm.py
test_02_restore_vm_strict_tags_failure Error 55.85 test_vm_strict_host_tags.py

@blueorangutan
Copy link

[SF] Trillian test result (tid-13210)
Environment: xenserver-84 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 67815 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10684-t13210-xenserver-84.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup Error 7.50 test_network.py

@blueorangutan
Copy link

[SF] Trillian test result (tid-13211)
Environment: xcpng83 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 74220 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10684-t13211-xcpng83.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup Error 7.55 test_network.py

@blueorangutan
Copy link

[SF] Trillian test result (tid-13209)
Environment: xcpng82 (x2), Advanced Networking with Mgmt server ol9
Total time taken: 82436 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10684-t13209-xcpng82.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup Error 10.60 test_network.py
test_10_list_volumes Failure 371.05 test_volumes.py

@Pearl1594
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13297

@github-project-automation github-project-automation bot moved this from In Progress to Done in ACS 4.20.1 May 9, 2025
@rohityadavcloud
Copy link
Member

@blueorangutan test ol8 xcpng83

@blueorangutan
Copy link

@rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + xcpng83) has been kicked to run smoke tests

harikrishna-patnala
harikrishna-patnala approved these changes May 9, 2025
View reviewed changes
Copy link
Contributor

@harikrishna-patnala harikrishna-patnala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes LGTM

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 9, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 40%)
C Maintainability Rating on New Code (required ≥ B)
C Reliability Rating on New Code (required ≥ B)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@Pearl1594 Pearl1594 moved this from Done to In Progress in ACS 4.20.1 May 9, 2025
@blueorangutan
Copy link

[SF] Trillian test result (tid-13242)
Environment: xcpng83 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 75161 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10684-t13242-xcpng83.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup Error 1532.02 test_network.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohityadavcloud rohityadavcloud rohityadavcloud approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@harikrishna-patnala harikrishna-patnala harikrishna-patnala approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

Assignees

@borisstoyanov borisstoyanov

Labels
component:build component:integration-test component:secondary-storage component:ssvm component:XenServer Python Warning... Python code Ahead! status:needs-testing
Projects
ACS 4.20.1
Status: In Progress
Milestone
4.20.1
Development

Successfully merging this pull request may close these issues.
9 participants
@Pearl1594 @blueorangutan @weizhouapache @rohityadavcloud @olivierlambert @bleader @DaanHoogland @harikrishna-patnala @borisstoyanov