Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Veeam: get templateId from vm instance if vm is created from ISO #10705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 4.19
Choose a base branch
from
Open

Veeam: get templateId from vm instance if vm is created from ISO #10705

wants to merge 1 commit into from

Conversation

weizhouapache
Copy link
Member

Description

This PR fixes #9440

The ROOT volume of vm from ISO does not have template_id (which is NULL)
We can get the template_id of vm_instance instead

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache weizhouapache linked an issue Apr 14, 2025 that may be closed by this pull request
Veeam Backup => Assign Backup Problem #9440
Open
DaanHoogland
DaanHoogland approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
Copy link
Contributor

@weizhouapache , I think we can suffice with a unit test for this one, do you agree?

@codecov Codecov
Copy link

codecov bot commented Apr 14, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 15.16%. Comparing base (99ea77d) to head (2791ec5).
Report is 28 commits behind head on 4.19.

Files with missing lines Patch % Lines
...ain/java/com/cloud/hypervisor/guru/VMwareGuru.java 0.00% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##               4.19   #10705   +/-   ##
=========================================
  Coverage     15.16%   15.16%           
- Complexity    11327    11332    +5     
=========================================
  Files          5415     5415           
  Lines        474848   474852    +4     
  Branches      57914    57915    +1     
=========================================
+ Hits          72018    72035   +17     
+ Misses       394781   394762   -19     
- Partials       8049     8055    +6
Flag Coverage Δ
uitests 4.28% <ø> (ø)
unittests 15.89% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@weizhouapache
Copy link
Member Author

@weizhouapache , I think we can suffice with a unit test for this one, do you agree?

yes, will add @DaanHoogland

harikrishna-patnala
harikrishna-patnala approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@harikrishna-patnala harikrishna-patnala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@weizhouapache weizhouapache marked this pull request as ready for review April 15, 2025 12:42
@weizhouapache
Copy link
Member Author

weizhouapache commented Apr 17, 2025 •
edited
Loading

@weizhouapache , I think we can suffice with a unit test for this one, do you agree?

yes, will add @DaanHoogland

it seems it needs much effort to add the unit test,as the VMGuruTest does not have unit test for getImportingVMTemplate method
I will not do it now
cc @DaanHoogland

@rohityadavcloud rohityadavcloud added this to the 4.19.3 milestone May 9, 2025
@rohityadavcloud
Copy link
Member

@blueorangutan package

@blueorangutan
Copy link

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13310

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@harikrishna-patnala harikrishna-patnala harikrishna-patnala approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

Assignees
No one assigned
Labels
component:vmware status:needs-testing
Projects
None yet
Milestone
4.19.3
Development

Successfully merging this pull request may close these issues.

Veeam Backup => Assign Backup Problem
6 participants
@weizhouapache @DaanHoogland @rohityadavcloud @blueorangutan @harikrishna-patnala @sureshanaparti