Thanks to visit codestin.com
Credit goes to github.com

Skip to content

plugin/shutdown: use mgmt server uuid in the shutdown response #10717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2025
Merged

plugin/shutdown: use mgmt server uuid in the shutdown response #10717

merged 1 commit into from
Apr 18, 2025

Conversation

rohityadavcloud
Copy link
Member

Fixes #10669

Creates shutdown response to use management server UUID than internal DB ID.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

@rohityadavcloud
plugin/shutdown: use mgmt server uuid in the shutdown response
bfc0af5 
Fixes apache#10669

Creates shutdown response to use management server UUID than internal DB
ID.

Signed-off-by: Rohit Yadav <[email protected]>
@rohityadavcloud rohityadavcloud added this to the 4.19.3 milestone Apr 15, 2025
@rohityadavcloud rohityadavcloud mentioned this pull request Apr 15, 2025
Closed
@rohityadavcloud rohityadavcloud linked an issue Apr 15, 2025 that may be closed by this pull request
managementserverid value inconsistency in shutdown APIs #10669
Closed
@rohityadavcloud
Copy link
Member Author

@blueorangutan package

@codecov Codecov
Copy link

codecov bot commented Apr 15, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 15.17%. Comparing base (f13cf59) to head (bfc0af5).
Report is 5 commits behind head on 4.19.

Files with missing lines Patch % Lines
...pache/cloudstack/shutdown/ShutdownManagerImpl.java 0.00% 3 Missing ⚠️
...udstack/api/response/ReadyForShutdownResponse.java 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##               4.19   #10717   +/-   ##
=========================================
  Coverage     15.17%   15.17%           
  Complexity    11332    11332           
=========================================
  Files          5415     5415           
  Lines        474893   474889    -4     
  Branches      57920    57920           
=========================================
+ Hits          72046    72047    +1     
+ Misses       394792   394788    -4     
+ Partials       8055     8054    -1
Flag Coverage Δ
uitests 4.28% <ø> (ø)
unittests 15.89% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

DaanHoogland
DaanHoogland approved these changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13057

@DaanHoogland
Copy link
Contributor

@blueorangutan test

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-12997)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 48879 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10717-t12997-kvm-ol8.zip
Smoke tests completed. 131 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_02_list_cpvm_vm Failure 0.07 test_ssvm.py
test_04_cpvm_internals Failure 0.06 test_ssvm.py
test_12_destroy_cpvm Error 3.29 test_ssvm.py
test_01_secure_vm_migration Error 135.99 test_vm_life_cycle.py
test_01_secure_vm_migration Error 135.99 test_vm_life_cycle.py

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-13011)

@borisstoyanov borisstoyanov self-assigned this Apr 16, 2025
@borisstoyanov
Copy link
Contributor

@blueorangutan test

borisstoyanov
borisstoyanov approved these changes Apr 16, 2025
View reviewed changes
Copy link
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've manually checked it, let's wait for one more round of smoke tests to pass, so that we confirm intermittent failures.

sureshanaparti
sureshanaparti approved these changes Apr 16, 2025
View reviewed changes
Copy link
Contributor

@sureshanaparti sureshanaparti left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm (@DaanHoogland this plugin is updated to ms maintenance plugin in main branch, ref: #9854 & this uuid changes are already addressed. only forward merge to 4.20, not main)

@rohityadavcloud
Copy link
Member Author

Thanks @sureshanaparti I didn't know on main it's already fixed. Thanks for checking.

@blueorangutan test

@blueorangutan
Copy link

@rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-13033)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 54555 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10717-t13033-kvm-ol8.zip
Smoke tests completed. 131 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_02_create_iso_with_checksum_sha256 Error 66.80 test_iso.py
test_02_unsecure_vm_migration Error 452.70 test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration Error 383.75 test_vm_life_cycle.py

@DaanHoogland DaanHoogland merged commit 29e58e9 into apache:4.19 Apr 18, 2025
24 of 25 checks passed
@DaanHoogland DaanHoogland deleted the prepshutdown-uuid-response branch April 18, 2025 09:09
DaanHoogland added a commit that referenced this pull request Apr 18, 2025
@DaanHoogland
Merge release branch 4.19 to 4.20
2771586 
* 4.19:
  plugin/shutdown: use mgmt server uuid in the shutdown response (#10717)
@DaanHoogland DaanHoogland linked an issue Apr 18, 2025 that may be closed by this pull request
prepareForShutdown reflects invalid state for shutdowntriggered #10670
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

@borisstoyanov borisstoyanov borisstoyanov approved these changes

Assignees

@borisstoyanov borisstoyanov

Labels
None yet
Projects
None yet
Milestone
4.19.3
5 participants
@rohityadavcloud @blueorangutan @DaanHoogland @borisstoyanov @sureshanaparti