-
Notifications
You must be signed in to change notification settings - Fork 1.2k
added: rosi as a contributor #10724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added: rosi as a contributor #10724
Conversation
Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
76d6435
to
a3176c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10724 +/- ##
=========================================
Coverage 16.30% 16.30%
- Complexity 13445 13448 +3
=========================================
Files 5676 5676
Lines 499241 499241
Branches 60377 60377
=========================================
+ Hits 81408 81418 +10
+ Misses 408767 408751 -16
- Partials 9066 9072 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Awesome work, congrats on your first merged pull request! |
Description
This PR...
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?