Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ui: trim whitespace from api params #10737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: 4.19
Choose a base branch
from
Draft

ui: trim whitespace from api params #10737

wants to merge 1 commit into from

Conversation

shwstppr
Copy link
Contributor

Description

Fixes #10627

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@shwstppr shwstppr mentioned this pull request Apr 16, 2025
Closed
@shwstppr
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@codecov Codecov
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.29%. Comparing base (f13cf59) to head (ad9879b).

❗ There is a different number of reports uploaded between BASE (f13cf59) and HEAD (ad9879b). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (f13cf59) HEAD (ad9879b)
unittests 1 0
Additional details and impacted files 
@@              Coverage Diff              @@
##               4.19   #10737       +/-   ##
=============================================
- Coverage     15.17%    4.29%   -10.88%     
=============================================
  Files          5415      369     -5046     
  Lines        474893    29674   -445219     
  Branches      57920     5208    -52712     
=============================================
- Hits          72046     1274    -70772     
+ Misses       394792    28255   -366537     
+ Partials       8055      145     -7910
Flag Coverage Δ
uitests 4.29% <ø> (+<0.01%) ⬆️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10737 (QA-JID-601)

DaanHoogland
DaanHoogland reviewed Apr 16, 2025
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm, but I wonder if really all string parameters would never want to allow spaces.

weizhouapache
weizhouapache approved these changes Apr 16, 2025
View reviewed changes
Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@weizhouapache
Copy link
Member

clgtm, but I wonder if really all string parameters would never want to allow spaces.

good point
need to go through the api parameters

@weizhouapache
Copy link
Member

@blueorangutan ui

@blueorangutan
Copy link

@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10737 (QA-JID-607)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaanHoogland DaanHoogland DaanHoogland left review comments

@weizhouapache weizhouapache weizhouapache approved these changes

Assignees
No one assigned
Labels
component:UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shwstppr @blueorangutan @weizhouapache @DaanHoogland