@blueorangutan package

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 16.02%. Comparing base (a09354d) to head (4c6aa55).
Report is 23 commits behind head on 4.20.

@@            Coverage Diff            @@
##               4.20   #10738   +/-   ##
=========================================
  Coverage     16.01%   16.02%           
  Complexity    13123    13123           
=========================================
  Files          5652     5652           
  Lines        495921   495921           
  Branches      60053    60053           
=========================================
+ Hits          79446    79451    +5     
+ Misses       407611   407607    -4     
+ Partials       8864     8863    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Re-kicking smoketests in Github Actions.

@blueorangutan package

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 13077

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 13076

I remember there is a similar method, so looked for it

cloudstack/engine/schema/src/main/java/com/cloud/dc/dao/ClusterDaoImpl.java

Lines 168 to 178 in 55c8115

	public List<HypervisorType> getAvailableHypervisorInZone(Long zoneId) {
	SearchCriteria<ClusterVO> sc = AvailHyperSearch.create();
	if (zoneId != null) {
	sc.setParameters("zoneId", zoneId);
	}
	List<ClusterVO> clusters = listBy(sc);
	return clusters.stream()
	.map(ClusterVO::getHypervisorType)
	.distinct()
	.collect(Collectors.toList());
	}

nice find @weizhouapache , do you mean we should make a template method?

@shwstppr can you review and fix the build/CI failures?

I remember there is a similar method, so looked for it

cloudstack/engine/schema/src/main/java/com/cloud/dc/dao/ClusterDaoImpl.java

Lines 168 to 178 in 55c8115

	public List<HypervisorType> getAvailableHypervisorInZone(Long zoneId) {
	SearchCriteria<ClusterVO> sc = AvailHyperSearch.create();
	if (zoneId != null) {
	sc.setParameters("zoneId", zoneId);
	}
	List<ClusterVO> clusters = listBy(sc);
	return clusters.stream()
	.map(ClusterVO::getHypervisorType)
	.distinct()
	.collect(Collectors.toList());
	}

@weizhouapache are you suggesting using ClusterDao method here or in the callers itself?

@blueorangutan package

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

I remember there is a similar method, so looked for it

cloudstack/engine/schema/src/main/java/com/cloud/dc/dao/ClusterDaoImpl.java

Lines 168 to 178 in 55c8115

	public List<HypervisorType> getAvailableHypervisorInZone(Long zoneId) {
	SearchCriteria<ClusterVO> sc = AvailHyperSearch.create();
	if (zoneId != null) {
	sc.setParameters("zoneId", zoneId);
	}
	List<ClusterVO> clusters = listBy(sc);
	return clusters.stream()
	.map(ClusterVO::getHypervisorType)
	.distinct()
	.collect(Collectors.toList());
	}

@weizhouapache are you suggesting using ClusterDao method here or in the callers itself?

if the method returns the same result, we can use it.
the code can be simple as

    @Override
    public List<HypervisorType> listAvailHypervisorInZone(final Long zoneId) {
        return _clusterDao.getAvailableHypervisorInZone(zoneId);
    }

if there is a cluster without any host, then the results will be different ..

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13088

Thanks @weizhouapache . It seems HostDao and ClusterDao can return different results. Maybe we can have a separate refactor to consolidate this or should I make the change here to use ClusterDao?

@blueorangutan test

@shwstppr a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[SF] Trillian test result (tid-13072)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 51906 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10738-t13072-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

@shwstppr , this looks ready to merge, do you feel it is ready?

@DaanHoogland yes. Marked it ready for review